* [PATCH V4 1/5] DMA: PL330: Add new pl330 filter for DT case.
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
@ 2013-02-11 8:38 ` Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 2/5] DMA: PL330: Add xlate function Padmavathi Venna
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Padmavathi Venna @ 2013-02-11 8:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, jassisinghbrar, arnd, vinod.koul,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
This patch adds a new pl330_dt_filter for DT case to filter the
required channel based on the new filter params and modifies the
old filter only for non-DT case as suggested by Arnd Bergmann.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/pl330.c | 29 +++++++++++++++--------------
1 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 80680ee..87110f2 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -606,6 +606,11 @@ struct dma_pl330_desc {
struct dma_pl330_chan *pchan;
};
+struct dma_pl330_filter_args {
+ struct dma_pl330_dmac *pdmac;
+ unsigned int chan_id;
+};
+
static inline void _callback(struct pl330_req *r, enum pl330_op_err err)
{
if (r && r->xfer_cb)
@@ -2352,6 +2357,16 @@ static void dma_pl330_rqcb(void *token, enum pl330_op_err err)
tasklet_schedule(&pch->task);
}
+static bool pl330_dt_filter(struct dma_chan *chan, void *param)
+{
+ struct dma_pl330_filter_args *fargs = param;
+
+ if (chan->device != &fargs->pdmac->ddma)
+ return false;
+
+ return (chan->chan_id == fargs->chan_id);
+}
+
bool pl330_filter(struct dma_chan *chan, void *param)
{
u8 *peri_id;
@@ -2359,20 +2374,6 @@ bool pl330_filter(struct dma_chan *chan, void *param)
if (chan->device->dev->driver != &pl330_driver.drv)
return false;
-#ifdef CONFIG_OF
- if (chan->device->dev->of_node) {
- const __be32 *prop_value;
- phandle phandle;
- struct device_node *node;
-
- prop_value = ((struct property *)param)->value;
- phandle = be32_to_cpup(prop_value++);
- node = of_find_node_by_phandle(phandle);
- return ((chan->private == node) &&
- (chan->chan_id == be32_to_cpup(prop_value)));
- }
-#endif
-
peri_id = chan->private;
return *peri_id == (unsigned)param;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V4 2/5] DMA: PL330: Add xlate function
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 1/5] DMA: PL330: Add new pl330 filter for DT case Padmavathi Venna
@ 2013-02-11 8:38 ` Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 3/5] DMA: PL330: Register the DMA controller with the generic DMA helpers Padmavathi Venna
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Padmavathi Venna @ 2013-02-11 8:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, jassisinghbrar, arnd, vinod.koul,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
Add xlate to translate the device-tree binding information into
the appropriate format. The filter function requires the dma
controller device and dma channel number as filter_params.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/pl330.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 87110f2..e68c83b 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -25,6 +25,7 @@
#include <linux/amba/pl330.h>
#include <linux/scatterlist.h>
#include <linux/of.h>
+#include <linux/of_dma.h>
#include "dmaengine.h"
#define PL330_MAX_CHAN 8
@@ -2379,6 +2380,30 @@ bool pl330_filter(struct dma_chan *chan, void *param)
}
EXPORT_SYMBOL(pl330_filter);
+static struct dma_chan *of_dma_pl330_xlate(struct of_phandle_args *dma_spec,
+ struct of_dma *ofdma)
+{
+ int count = dma_spec->args_count;
+ struct dma_pl330_dmac *pdmac = ofdma->of_dma_data;
+ struct dma_pl330_filter_args fargs;
+ dma_cap_mask_t cap;
+
+ if (!pdmac)
+ return NULL;
+
+ if (count != 1)
+ return NULL;
+
+ fargs.pdmac = pdmac;
+ fargs.chan_id = dma_spec->args[0];
+
+ dma_cap_zero(cap);
+ dma_cap_set(DMA_SLAVE, cap);
+ dma_cap_set(DMA_CYCLIC, cap);
+
+ return dma_request_channel(cap, pl330_dt_filter, &fargs);
+}
+
static int pl330_alloc_chan_resources(struct dma_chan *chan)
{
struct dma_pl330_chan *pch = to_pchan(chan);
--
1.7.4.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V4 3/5] DMA: PL330: Register the DMA controller with the generic DMA helpers
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 1/5] DMA: PL330: Add new pl330 filter for DT case Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 2/5] DMA: PL330: Add xlate function Padmavathi Venna
@ 2013-02-11 8:38 ` Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 4/5] ARM: dts: pl330: Add #dma-cells for generic dma binding support Padmavathi Venna
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Padmavathi Venna @ 2013-02-11 8:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, jassisinghbrar, arnd, vinod.koul,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
This patch registers the pl330 dma controller driver with the generic
device tree dma helper functions.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/pl330.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index e68c83b..3fca247 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2999,6 +2999,14 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
pi->pcfg.data_bus_width / 8, pi->pcfg.num_chan,
pi->pcfg.num_peri, pi->pcfg.num_events);
+ ret = of_dma_controller_register(adev->dev.of_node,
+ of_dma_pl330_xlate, pdmac);
+ if (ret) {
+ dev_err(&adev->dev,
+ "unable to register DMA to the generic DT DMA helpers\n");
+ goto probe_err2;
+ }
+
return 0;
probe_err4:
@@ -3025,6 +3033,8 @@ static int pl330_remove(struct amba_device *adev)
if (!pdmac)
return 0;
+ of_dma_controller_free(adev->dev.of_node);
+
amba_set_drvdata(adev, NULL);
/* Idle the DMAC */
--
1.7.4.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V4 4/5] ARM: dts: pl330: Add #dma-cells for generic dma binding support
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
` (2 preceding siblings ...)
2013-02-11 8:38 ` [PATCH V4 3/5] DMA: PL330: Register the DMA controller with the generic DMA helpers Padmavathi Venna
@ 2013-02-11 8:38 ` Padmavathi Venna
2013-02-11 8:38 ` [PATCH V4 5/5] ARM: SAMSUNG: dma: Remove unnecessary code Padmavathi Venna
2013-02-12 14:49 ` [PATCH V4 0/5] Add generic DMA DT binding support Vinod Koul
5 siblings, 0 replies; 11+ messages in thread
From: Padmavathi Venna @ 2013-02-11 8:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, jassisinghbrar, arnd, vinod.koul,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
This patch adds #dma-cells property to PL330 DMA controller
nodes for supporting generic dma dt bindings on samsung
exynos5250 platform.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
.../devicetree/bindings/dma/arm-pl330.txt | 21 +++++++++++++++----
arch/arm/boot/dts/exynos5250.dtsi | 12 +++++++++++
2 files changed, 28 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/arm-pl330.txt b/Documentation/devicetree/bindings/dma/arm-pl330.txt
index 36e27d5..2675658 100644
--- a/Documentation/devicetree/bindings/dma/arm-pl330.txt
+++ b/Documentation/devicetree/bindings/dma/arm-pl330.txt
@@ -10,7 +10,11 @@ Required properties:
- interrupts: interrupt number to the cpu.
Optional properties:
-- dma-coherent : Present if dma operations are coherent
+ - dma-coherent : Present if dma operations are coherent
+ - #dma-cells: must be <1>. used to represent the number of integer
+ cells in the dmas property of client device.
+ - dma-channels: contains the total number of DMA channels supported by the DMAC
+ - dma-requests: contains the total number of DMA requests supported by the DMAC
Example:
@@ -18,16 +22,23 @@ Example:
compatible = "arm,pl330", "arm,primecell";
reg = <0x12680000 0x1000>;
interrupts = <99>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
};
Client drivers (device nodes requiring dma transfers from dev-to-mem or
-mem-to-dev) should specify the DMA channel numbers using a two-value pair
+mem-to-dev) should specify the DMA channel numbers and dma channel names
as shown below.
[property name] = <[phandle of the dma controller] [dma request id]>;
+ [property name] = <[dma channel name]>
where 'dma request id' is the dma request number which is connected
- to the client controller. The 'property name' is recommended to be
- of the form <name>-dma-channel.
+ to the client controller. The 'property name' 'dmas' and 'dma-names'
+ as required by the generic dma device tree binding helpers. The dma
+ names correspond 1:1 with the dma request ids in the dmas property.
- Example: tx-dma-channel = <&pdma0 12>;
+ Example: dmas = <&pdma0 12
+ &pdma1 11>;
+ dma-names = "tx", "rx";
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f50b4e8..b1ac73e 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -312,24 +312,36 @@
compatible = "arm,pl330", "arm,primecell";
reg = <0x121A0000 0x1000>;
interrupts = <0 34 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
};
pdma1: pdma@121B0000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x121B0000 0x1000>;
interrupts = <0 35 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
};
mdma0: mdma@10800000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x10800000 0x1000>;
interrupts = <0 33 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <1>;
};
mdma1: mdma@11C10000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x11C10000 0x1000>;
interrupts = <0 124 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <1>;
};
};
--
1.7.4.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH V4 5/5] ARM: SAMSUNG: dma: Remove unnecessary code
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
` (3 preceding siblings ...)
2013-02-11 8:38 ` [PATCH V4 4/5] ARM: dts: pl330: Add #dma-cells for generic dma binding support Padmavathi Venna
@ 2013-02-11 8:38 ` Padmavathi Venna
2013-02-12 14:49 ` [PATCH V4 0/5] Add generic DMA DT binding support Vinod Koul
5 siblings, 0 replies; 11+ messages in thread
From: Padmavathi Venna @ 2013-02-11 8:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, jassisinghbrar, arnd, vinod.koul,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
This patch removes the usage of DMACH_DT_PROP and dt_dmach_prop
from dma code as the new generic dma dt binding support has been
added.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-s3c24xx/include/mach/dma.h | 1 -
arch/arm/mach-s3c64xx/include/mach/dma.h | 1 -
arch/arm/plat-samsung/dma-ops.c | 10 +---------
arch/arm/plat-samsung/include/plat/dma-ops.h | 1 -
arch/arm/plat-samsung/include/plat/dma-pl330.h | 1 -
5 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/include/mach/dma.h b/arch/arm/mach-s3c24xx/include/mach/dma.h
index 6b72d5a..b55da1d 100644
--- a/arch/arm/mach-s3c24xx/include/mach/dma.h
+++ b/arch/arm/mach-s3c24xx/include/mach/dma.h
@@ -24,7 +24,6 @@
*/
enum dma_ch {
- DMACH_DT_PROP = -1, /* not yet supported, do not use */
DMACH_XD0 = 0,
DMACH_XD1,
DMACH_SDI,
diff --git a/arch/arm/mach-s3c64xx/include/mach/dma.h b/arch/arm/mach-s3c64xx/include/mach/dma.h
index 57b1ff4..fe1a98c 100644
--- a/arch/arm/mach-s3c64xx/include/mach/dma.h
+++ b/arch/arm/mach-s3c64xx/include/mach/dma.h
@@ -21,7 +21,6 @@
*/
enum dma_ch {
/* DMA0/SDMA0 */
- DMACH_DT_PROP = -1, /* not yet supported, do not use */
DMACH_UART0 = 0,
DMACH_UART0_SRC2,
DMACH_UART1,
diff --git a/arch/arm/plat-samsung/dma-ops.c b/arch/arm/plat-samsung/dma-ops.c
index 71d58dd..ec0d731 100644
--- a/arch/arm/plat-samsung/dma-ops.c
+++ b/arch/arm/plat-samsung/dma-ops.c
@@ -23,23 +23,15 @@ static unsigned samsung_dmadev_request(enum dma_ch dma_ch,
struct device *dev, char *ch_name)
{
dma_cap_mask_t mask;
- void *filter_param;
dma_cap_zero(mask);
dma_cap_set(param->cap, mask);
- /*
- * If a dma channel property of a device node from device tree is
- * specified, use that as the fliter parameter.
- */
- filter_param = (dma_ch == DMACH_DT_PROP) ?
- (void *)param->dt_dmach_prop : (void *)dma_ch;
-
if (dev->of_node)
return (unsigned)dma_request_slave_channel(dev, ch_name);
else
return (unsigned)dma_request_channel(mask, pl330_filter,
- filter_param);
+ (void *)dma_ch);
}
static int samsung_dmadev_release(unsigned ch, void *param)
diff --git a/arch/arm/plat-samsung/include/plat/dma-ops.h b/arch/arm/plat-samsung/include/plat/dma-ops.h
index 1141782..ce6d763 100644
--- a/arch/arm/plat-samsung/include/plat/dma-ops.h
+++ b/arch/arm/plat-samsung/include/plat/dma-ops.h
@@ -18,7 +18,6 @@
struct samsung_dma_req {
enum dma_transaction_type cap;
- struct property *dt_dmach_prop;
struct s3c2410_dma_client *client;
};
diff --git a/arch/arm/plat-samsung/include/plat/dma-pl330.h b/arch/arm/plat-samsung/include/plat/dma-pl330.h
index d384a80..abe07fa 100644
--- a/arch/arm/plat-samsung/include/plat/dma-pl330.h
+++ b/arch/arm/plat-samsung/include/plat/dma-pl330.h
@@ -21,7 +21,6 @@
* use these just as IDs.
*/
enum dma_ch {
- DMACH_DT_PROP = -1,
DMACH_UART0_RX = 0,
DMACH_UART0_TX,
DMACH_UART1_RX,
--
1.7.4.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH V4 0/5] Add generic DMA DT binding support
2013-02-11 8:38 [PATCH V4 0/5] Add generic DMA DT binding support Padmavathi Venna
` (4 preceding siblings ...)
2013-02-11 8:38 ` [PATCH V4 5/5] ARM: SAMSUNG: dma: Remove unnecessary code Padmavathi Venna
@ 2013-02-12 14:49 ` Vinod Koul
2013-02-13 4:22 ` Padma Venkat
5 siblings, 1 reply; 11+ messages in thread
From: Vinod Koul @ 2013-02-12 14:49 UTC (permalink / raw)
To: Padmavathi Venna
Cc: linux-samsung-soc, devicetree-discuss, linux-arm-kernel,
padma.kvr, sbkim73, broonie, kgene.kim, jassisinghbrar, arnd,
grant.likely, jon-hunter, boojin.kim, thomas.abraham, robherring2
On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
This looks fine, I have only question. The code seems to assume that pl330 dma
controller always uses DT. But I dont see that as dependency for pl330.
Something tells me withot OF the driver may not build, have you checked it?
> This patch set adds support for generic dma device tree bindings for
> Samsung platforms and is dependent on the following patches from
> Vinod Koul next branch
> 1)of: Add generic device tree DMA helpers
> 2)dmaengine: add helper function to request a slave DMA channel
>
> This patch set is made based Mark Brown next branch
Is this targetted for ASoC tree, if so why? It would fail to build if applied
there
--
~Vinod
>
> Padmavathi Venna (5):
> DMA: PL330: Add new pl330 filter for DT case.
> DMA: PL330: Add xlate function
> DMA: PL330: Register the DMA controller with the generic DMA helpers
> ARM: dts: pl330: Add #dma-cells for generic dma binding support
> ARM: SAMSUNG: dma: Remove unnecessary code
>
> .../devicetree/bindings/dma/arm-pl330.txt | 21 +++++--
> arch/arm/boot/dts/exynos5250.dtsi | 12 ++++
> arch/arm/mach-s3c24xx/include/mach/dma.h | 1 -
> arch/arm/mach-s3c64xx/include/mach/dma.h | 1 -
> arch/arm/plat-samsung/dma-ops.c | 10 +---
> arch/arm/plat-samsung/include/plat/dma-ops.h | 1 -
> arch/arm/plat-samsung/include/plat/dma-pl330.h | 1 -
> drivers/dma/pl330.c | 64 +++++++++++++++----
> 8 files changed, 79 insertions(+), 32 deletions(-)
>
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH V4 0/5] Add generic DMA DT binding support
2013-02-12 14:49 ` [PATCH V4 0/5] Add generic DMA DT binding support Vinod Koul
@ 2013-02-13 4:22 ` Padma Venkat
2013-02-14 4:47 ` Vinod Koul
0 siblings, 1 reply; 11+ messages in thread
From: Padma Venkat @ 2013-02-13 4:22 UTC (permalink / raw)
To: Vinod Koul
Cc: Padmavathi Venna, linux-samsung-soc, devicetree-discuss,
linux-arm-kernel, sbkim73, broonie, kgene.kim, jassisinghbrar,
arnd, grant.likely, jon-hunter, boojin.kim, thomas.abraham,
robherring2
Hi Vinod,
On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
>
> This looks fine, I have only question. The code seems to assume that pl330 dma
> controller always uses DT. But I dont see that as dependency for pl330.
>
> Something tells me withot OF the driver may not build, have you checked it?
>
>> This patch set adds support for generic dma device tree bindings for
>> Samsung platforms and is dependent on the following patches from
>> Vinod Koul next branch
>> 1)of: Add generic device tree DMA helpers
>> 2)dmaengine: add helper function to request a slave DMA channel
>>
>> This patch set is made based Mark Brown next branch
> Is this targetted for ASoC tree, if so why? It would fail to build if applied
> there
I have done this for my testing purpose (I expected all will directly
apply in your branch). But 3rd patch is not applied directly. I will
resend the patches after re-basing on your tree. 5th patch has to go
in ASoC tree because it has dependency on "ARM: SAMSUNG: Make dma
request compatible to generic dma bindings" which is there in ASoC
tree.
Hi Mark,
Can you please take the 5th patch in your tree(if there is no issue)
or should I resend it as a separate patch?
>
> --
> ~Vinod
>>
>> Padmavathi Venna (5):
>> DMA: PL330: Add new pl330 filter for DT case.
>> DMA: PL330: Add xlate function
>> DMA: PL330: Register the DMA controller with the generic DMA helpers
>> ARM: dts: pl330: Add #dma-cells for generic dma binding support
>> ARM: SAMSUNG: dma: Remove unnecessary code
>>
>> .../devicetree/bindings/dma/arm-pl330.txt | 21 +++++--
>> arch/arm/boot/dts/exynos5250.dtsi | 12 ++++
>> arch/arm/mach-s3c24xx/include/mach/dma.h | 1 -
>> arch/arm/mach-s3c64xx/include/mach/dma.h | 1 -
>> arch/arm/plat-samsung/dma-ops.c | 10 +---
>> arch/arm/plat-samsung/include/plat/dma-ops.h | 1 -
>> arch/arm/plat-samsung/include/plat/dma-pl330.h | 1 -
>> drivers/dma/pl330.c | 64 +++++++++++++++----
>> 8 files changed, 79 insertions(+), 32 deletions(-)
>>
>> --
>> 1.7.4.4
>>
Thanks
Padma
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V4 0/5] Add generic DMA DT binding support
2013-02-13 4:22 ` Padma Venkat
@ 2013-02-14 4:47 ` Vinod Koul
2013-02-14 5:42 ` Padma Venkat
0 siblings, 1 reply; 11+ messages in thread
From: Vinod Koul @ 2013-02-14 4:47 UTC (permalink / raw)
To: Padma Venkat
Cc: Padmavathi Venna, linux-samsung-soc, devicetree-discuss,
linux-arm-kernel, sbkim73, broonie, kgene.kim, jassisinghbrar,
arnd, grant.likely, jon-hunter, boojin.kim, thomas.abraham,
robherring2
On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote:
> Hi Vinod,
>
> On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
> >
> > This looks fine, I have only question. The code seems to assume that pl330 dma
> > controller always uses DT. But I dont see that as dependency for pl330.
Have you checked this?
> > Something tells me withot OF the driver may not build, have you checked it?
> >
> >> This patch set adds support for generic dma device tree bindings for
> >> Samsung platforms and is dependent on the following patches from
> >> Vinod Koul next branch
> >> 1)of: Add generic device tree DMA helpers
> >> 2)dmaengine: add helper function to request a slave DMA channel
> >>
> >> This patch set is made based Mark Brown next branch
> > Is this targetted for ASoC tree, if so why? It would fail to build if applied
> > there
>
> I have done this for my testing purpose (I expected all will directly
> apply in your branch). But 3rd patch is not applied directly. I will
> resend the patches after re-basing on your tree. 5th patch has to go
> in ASoC tree because it has dependency on "ARM: SAMSUNG: Make dma
> request compatible to generic dma bindings" which is there in ASoC
> tree.
>
> Hi Mark,
>
> Can you please take the 5th patch in your tree(if there is no issue)
> or should I resend it as a separate patch?
>
> >
> > --
> > ~Vinod
> >>
> >> Padmavathi Venna (5):
> >> DMA: PL330: Add new pl330 filter for DT case.
> >> DMA: PL330: Add xlate function
> >> DMA: PL330: Register the DMA controller with the generic DMA helpers
> >> ARM: dts: pl330: Add #dma-cells for generic dma binding support
> >> ARM: SAMSUNG: dma: Remove unnecessary code
> >>
> >> .../devicetree/bindings/dma/arm-pl330.txt | 21 +++++--
> >> arch/arm/boot/dts/exynos5250.dtsi | 12 ++++
> >> arch/arm/mach-s3c24xx/include/mach/dma.h | 1 -
> >> arch/arm/mach-s3c64xx/include/mach/dma.h | 1 -
> >> arch/arm/plat-samsung/dma-ops.c | 10 +---
> >> arch/arm/plat-samsung/include/plat/dma-ops.h | 1 -
> >> arch/arm/plat-samsung/include/plat/dma-pl330.h | 1 -
> >> drivers/dma/pl330.c | 64 +++++++++++++++----
> >> 8 files changed, 79 insertions(+), 32 deletions(-)
> >>
> >> --
> >> 1.7.4.4
> >>
> Thanks
> Padma
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V4 0/5] Add generic DMA DT binding support
2013-02-14 4:47 ` Vinod Koul
@ 2013-02-14 5:42 ` Padma Venkat
2013-02-14 9:39 ` Vinod Koul
0 siblings, 1 reply; 11+ messages in thread
From: Padma Venkat @ 2013-02-14 5:42 UTC (permalink / raw)
To: Vinod Koul
Cc: Padmavathi Venna, linux-samsung-soc, devicetree-discuss,
linux-arm-kernel, sbkim73, broonie, kgene.kim, jassisinghbrar,
arnd, grant.likely, jon-hunter, boojin.kim, thomas.abraham,
robherring2
Hi Vinod,
On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote:
>> Hi Vinod,
>>
>> On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
>> >
>> > This looks fine, I have only question. The code seems to assume that pl330 dma
>> > controller always uses DT. But I dont see that as dependency for pl330.
> Have you checked this?
Sorry I didn't see this comment previously. I verified on SMDK6410
board which doesn't have DT support.
I didn't see any build error and it detected the sound card.
>
>> > Something tells me withot OF the driver may not build, have you checked it?
>> >
>> >> This patch set adds support for generic dma device tree bindings for
>> >> Samsung platforms and is dependent on the following patches from
>> >> Vinod Koul next branch
>> >> 1)of: Add generic device tree DMA helpers
>> >> 2)dmaengine: add helper function to request a slave DMA channel
>> >>
>> >> This patch set is made based Mark Brown next branch
>> > Is this targetted for ASoC tree, if so why? It would fail to build if applied
>> > there
>>
>> I have done this for my testing purpose (I expected all will directly
>> apply in your branch). But 3rd patch is not applied directly. I will
>> resend the patches after re-basing on your tree. 5th patch has to go
>> in ASoC tree because it has dependency on "ARM: SAMSUNG: Make dma
>> request compatible to generic dma bindings" which is there in ASoC
>> tree.
>>
>> Hi Mark,
>>
>> Can you please take the 5th patch in your tree(if there is no issue)
>> or should I resend it as a separate patch?
>>
>> >
>> > --
>> > ~Vinod
>> >>
>> >> Padmavathi Venna (5):
>> >> DMA: PL330: Add new pl330 filter for DT case.
>> >> DMA: PL330: Add xlate function
>> >> DMA: PL330: Register the DMA controller with the generic DMA helpers
>> >> ARM: dts: pl330: Add #dma-cells for generic dma binding support
>> >> ARM: SAMSUNG: dma: Remove unnecessary code
>> >>
>> >> .../devicetree/bindings/dma/arm-pl330.txt | 21 +++++--
>> >> arch/arm/boot/dts/exynos5250.dtsi | 12 ++++
>> >> arch/arm/mach-s3c24xx/include/mach/dma.h | 1 -
>> >> arch/arm/mach-s3c64xx/include/mach/dma.h | 1 -
>> >> arch/arm/plat-samsung/dma-ops.c | 10 +---
>> >> arch/arm/plat-samsung/include/plat/dma-ops.h | 1 -
>> >> arch/arm/plat-samsung/include/plat/dma-pl330.h | 1 -
>> >> drivers/dma/pl330.c | 64 +++++++++++++++----
>> >> 8 files changed, 79 insertions(+), 32 deletions(-)
>> >>
>> >> --
>> >> 1.7.4.4
>> >>
>> Thanks
>> Padma
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V4 0/5] Add generic DMA DT binding support
2013-02-14 5:42 ` Padma Venkat
@ 2013-02-14 9:39 ` Vinod Koul
0 siblings, 0 replies; 11+ messages in thread
From: Vinod Koul @ 2013-02-14 9:39 UTC (permalink / raw)
To: Padma Venkat
Cc: Padmavathi Venna, linux-samsung-soc, devicetree-discuss,
linux-arm-kernel, sbkim73, broonie, kgene.kim, jassisinghbrar,
arnd, grant.likely, jon-hunter, boojin.kim, thomas.abraham,
robherring2
On Thu, Feb 14, 2013 at 11:12:51AM +0530, Padma Venkat wrote:
> Hi Vinod,
>
> On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote:
> >> Hi Vinod,
> >>
> >> On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> >> > On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
> >> >
> >> > This looks fine, I have only question. The code seems to assume that pl330 dma
> >> > controller always uses DT. But I dont see that as dependency for pl330.
> > Have you checked this?
>
> Sorry I didn't see this comment previously. I verified on SMDK6410
> board which doesn't have DT support.
> I didn't see any build error and it detected the sound card.
Okay, sound good...
I will try the series now.
--
~Vinod
^ permalink raw reply [flat|nested] 11+ messages in thread