From: "Heiko Stübner" <heiko@sntech.de>
To: Kukjin Kim <kgene.kim@samsung.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Abraham <thomas.abraham@linaro.org>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416
Date: Mon, 18 Feb 2013 01:03:52 +0100 [thread overview]
Message-ID: <201302180103.53084.heiko@sntech.de> (raw)
This is the second installment of beginning devicetree support the
Samsung S3C24xx architectures and focuses on the s3c2416 for now.
Included is the devicetree support for the s3c24xx irq controller and
basic support for smdk2416 boards, which can sucessfully boot.
After the discussion with Thomas Abraham on v1 and staring to long at all of
this, I'm not even sure if having the interrupt mapping in the binding
is the correct way to go anymore.
The key positive aspect of this solution is, that after everything is running
via dt all the SoC specific mapping tables in the driver can go away, cutting
its length in half.
The other option would be as Thomas suggested to define specific irq-controller
types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and keep
the mapping data in the code, as it is now.
So I would be very thankful for a bit of guidance on what is the better way.
The series depends on the finalized s3c24xx irq rework, which probably won't
make it into 3.9 and also the clocksource dt support by Tomasz Figa, which
are not in any tree yet.
Changes since v1:
- adapt to changes in the underlying s3c24xx irq rework
= more shared init code
- use irqchip infrastructure
- limit number of possible irq-types to not encode implementation details
into the binding
- include new samsung-clocksource
Heiko Stuebner (3):
ARM: S3C24XX: move irq driver to drivers/irqchip
irqchip: irq-s3c24xx: add devicetree support
ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs
.../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++++++
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/s3c2416-smdk2416.dts | 79 ++++++++
arch/arm/boot/dts/s3c2416.dtsi | 193 ++++++++++++++++++++
arch/arm/boot/dts/s3c24xx.dtsi | 165 +++++++++++++++++
arch/arm/mach-s3c24xx/Kconfig | 10 +
arch/arm/mach-s3c24xx/Makefile | 3 +-
arch/arm/mach-s3c24xx/mach-s3c2416-dt.c | 91 +++++++++
drivers/irqchip/Makefile | 1 +
.../irq.c => drivers/irqchip/irq-s3c24xx.c | 128 +++++++++++++
10 files changed, 723 insertions(+), 1 deletions(-)
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/samsung,s3c24xx-irq.txt
create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts
create mode 100644 arch/arm/boot/dts/s3c2416.dtsi
create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi
create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
rename arch/arm/mach-s3c24xx/irq.c => drivers/irqchip/irq-s3c24xx.c (92%)
--
1.7.2.3
next reply other threads:[~2013-02-18 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 0:03 Heiko Stübner [this message]
2013-02-18 0:05 ` [PATCH v2 1/3] ARM: S3C24XX: move irq driver to drivers/irqchip Heiko Stübner
2013-02-18 0:06 ` [PATCH v2 2/3] irqchip: irq-s3c24xx: add devicetree support Heiko Stübner
2013-02-18 0:07 ` [PATCH v2 3/3] ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs Heiko Stübner
2013-04-10 10:15 ` [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416 Kukjin Kim
[not found] ` <30ff01ce35d4$5f4920d0$1ddb6270$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-04-10 10:37 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302180103.53084.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).