From: Mark Rutland <mark.rutland@arm.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"linux@simtec.co.uk" <linux@simtec.co.uk>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"kwangwoo.lee@gmail.com" <kwangwoo.lee@gmail.com>,
"jacmet@sunsite.dk" <jacmet@sunsite.dk>,
"augulis.darius@gmail.com" <augulis.darius@gmail.com>,
"mcuelenaere@gmail.com" <mcuelenaere@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
"buserror@gmail.com" <buserror@gmail.com>,
"christer@weinigel.se" <christer@weinigel.se>,
"jekhor@gmail.com" <jekhor@gmail.com>,
"ghcstop@gmail.com" <ghcstop@gmail.com>
Subject: Re: [PATCH v2 12/12] clocksource: samsung-time: Add Device Tree support
Date: Mon, 18 Feb 2013 09:48:12 +0000 [thread overview]
Message-ID: <20130218094812.GA23831@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1361033044-27629-13-git-send-email-tomasz.figa@gmail.com>
Hi,
[...]
> +static void samsung_timer_parse_dt(struct device_node *np,
> + const struct of_device_id *match)
> +{
> + int i;
> + u32 val;
> +
> + timer_base = of_iomap(np, 0);
> + if (!timer_base)
> + panic("failed to map timer registers");
> +
> + for (i = 0; i < SAMSUNG_PWM_NUM; ++i)
> + timer_variant.irqs[i] = irq_of_parse_and_map(np, i);
> +
> + if (!timer_variant.irqs[timer_source.event_id])
> + panic("no clock event irq provided");
> +
> + switch ((unsigned int)match->data) {
> + case TYPE_S3C24XX:
> + timer_variant.bits = 16;
> + timer_variant.prescale = 25;
> + timer_variant.prescale = 50;
Redundant conflicting assignments here.
Thanks,
Mark.
prev parent reply other threads:[~2013-02-18 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361033044-27629-1-git-send-email-tomasz.figa@gmail.com>
2013-02-16 16:44 ` [PATCH v2 12/12] clocksource: samsung-time: Add Device Tree support Tomasz Figa
2013-02-18 2:39 ` Rob Herring
2013-02-18 9:48 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218094812.GA23831@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=augulis.darius@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=buserror@gmail.com \
--cc=christer@weinigel.se \
--cc=ghcstop@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=jekhor@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@simtec.co.uk \
--cc=mcuelenaere@gmail.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).