From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support Date: Wed, 6 Mar 2013 14:07:52 +0100 Message-ID: <20130306140752.7e5d68c8@skate> References: <016b01ce18c2$2c366f10$84a34d30$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Thomas Abraham Cc: Jingoo Han , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Surendranath Gurivireddy Balla , Siva Reddy Kallam List-Id: devicetree@vger.kernel.org Dear Thomas Abraham, On Mon, 4 Mar 2013 16:01:59 +0530, Thomas Abraham wrote: > On 4 March 2013 15:52, Jingoo Han wrote: > > Exynos5440 has two PCIe controllers which can be used as Root Complex. > > This driver supports the PCIe controllers as Root Complex mode. > > > > Signed-off-by: Surendranath Gurivireddy Balla > > Signed-off-by: Siva Reddy Kallam > > Signed-off-by: Jingoo Han > > --- > > .../devicetree/bindings/pci/exynos-pcie.txt | 58 ++ > > arch/arm/Kconfig | 2 + > > arch/arm/mach-exynos/Kconfig | 8 + > > arch/arm/mach-exynos/Makefile | 2 + > > arch/arm/mach-exynos/include/mach/pcie.h | 146 +++ > > arch/arm/mach-exynos/pcie.c | 1009 ++++++++++++++++++++ > > Is there any reason to place this code in arch/arm/...? As you know, > there is a constant effort to relocate as much code as possible from > arch/arm/mach-exynos. So there must be a strong justification for > keeping this code in arch/arm/mach-exynos. Indeed. Thierry Reding (doing the Tegra PCIe driver) and myself (doing the Marvell PCIe driver) are putting our drivers in drivers/pci/host/, in agreement with the PCI maintainers. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com