* [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
@ 2013-03-13 5:32 Dan Carpenter
2013-03-13 10:29 ` Daniel Mack
2013-03-13 11:09 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-03-13 5:32 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, Takashi Iwai, devicetree-discuss, Mark Brown,
kernel-janitors, Rob Herring, Daniel Mack, Grant Likely, kbuild
"val" has to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 008bea4..41d03ae 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
{
struct snd_soc_codec *codec = dai->codec;
struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
- unsigned int val;
+ int val;
int ret;
priv->rate = params_rate(params);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
2013-03-13 5:32 [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params() Dan Carpenter
@ 2013-03-13 10:29 ` Daniel Mack
2013-03-13 11:09 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2013-03-13 10:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Takashi Iwai, devicetree-discuss, Mark Brown,
kernel-janitors, Liam Girdwood, Rob Herring, Grant Likely, kbuild
On 13.03.2013 06:32, Dan Carpenter wrote:
> "val" has to be signed for the error handling to work.
Absolutely.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
>
> diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
> index 008bea4..41d03ae 100644
> --- a/sound/soc/codecs/tas5086.c
> +++ b/sound/soc/codecs/tas5086.c
> @@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
> {
> struct snd_soc_codec *codec = dai->codec;
> struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
> - unsigned int val;
> + int val;
> int ret;
>
> priv->rate = params_rate(params);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
2013-03-13 5:32 [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params() Dan Carpenter
2013-03-13 10:29 ` Daniel Mack
@ 2013-03-13 11:09 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-03-13 11:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Takashi Iwai, devicetree-discuss, kernel-janitors,
Liam Girdwood, Rob Herring, Daniel Mack, Grant Likely, kbuild
[-- Attachment #1.1: Type: text/plain, Size: 138 bytes --]
On Wed, Mar 13, 2013 at 08:32:53AM +0300, Dan Carpenter wrote:
> "val" has to be signed for the error handling to work.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-13 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-13 5:32 [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params() Dan Carpenter
2013-03-13 10:29 ` Daniel Mack
2013-03-13 11:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).