From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: balbi@ti.com, b-cousson@ti.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10
Date: Wed, 13 Mar 2013 09:24:54 -0700 [thread overview]
Message-ID: <20130313162454.GE26093@atomide.com> (raw)
In-Reply-To: <5140821B.2030902@ti.com>
* Roger Quadros <rogerq@ti.com> [130313 06:46]:
> On 03/12/2013 06:40 PM, Tony Lindgren wrote:
> > * Roger Quadros <rogerq@ti.com> [130312 04:47]:
> >> Hi Tony,
> >>
> >> These patches provide the SoC side code required to support
> >> the changes in the OMAP USB Host drivers done in [1], [2] & [3].
> > ...
> >
> >> arch/arm/mach-omap2/board-3430sdp.c | 97 +++++++++++++++-
> >> arch/arm/mach-omap2/board-3630sdp.c | 100 +++++++++++++++-
> >> arch/arm/mach-omap2/board-am3517crane.c | 95 +++++++++++++--
> >> arch/arm/mach-omap2/board-am3517evm.c | 66 ++++++++++-
> >> arch/arm/mach-omap2/board-cm-t35.c | 95 ++++++++++++++-
> >> arch/arm/mach-omap2/board-cm-t3517.c | 97 +++++++++++++++-
> >> arch/arm/mach-omap2/board-devkit8000.c | 20 ++--
> >> arch/arm/mach-omap2/board-generic.c | 67 +++++++++++
> >> arch/arm/mach-omap2/board-igep0020.c | 112 ++++++++++++++++---
> >> arch/arm/mach-omap2/board-omap3beagle.c | 93 +++++++++++++--
> >> arch/arm/mach-omap2/board-omap3evm.c | 62 ++++++++--
> >> arch/arm/mach-omap2/board-omap3pandora.c | 52 +++++++--
> >> arch/arm/mach-omap2/board-omap3stalker.c | 52 +++++++-
> >> arch/arm/mach-omap2/board-omap3touchbook.c | 62 +++++++++-
> >> arch/arm/mach-omap2/board-omap4panda.c | 122 ++++++++++++++------
> >> arch/arm/mach-omap2/board-overo.c | 54 ++++++++-
> >> arch/arm/mach-omap2/board-zoom.c | 56 ++++++++-
> >
> > Can't you have some mach-omap2/ehci-common.c that takes care
> > of the initializiation to avoid this much addition to the
> > board-*.c files? You may be able to have just a common function
> > to do it and pass few parameters?
>
> Since we moved reset and power handling for the USB PHYs from omap-echi
> driver into the USB PHY driver we need to define the regulator data
> for RESET and Power line of each PHY. So most of the code added is just
> regulator data for the PHY rather than omap-ehci.
It seems that you're now repeating minor variations of the same PHY
over and over again though.
> Instead of a common function, I can implement some macros that make it
> easier to define the regulators for the PHY in the board files.
> Does this sound OK?
>
> Personally I don't like such macros because it hides the implementation
> and is difficult to read/debug.
I'd prefer a common function to initialize the PHY though as it sounds
like using macros would just allocate similar PHY many times which seems
unnecessary.
Regards,
Tony
next prev parent reply other threads:[~2013-03-13 16:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 11:43 [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Roger Quadros
2013-03-12 11:43 ` [PATCH 01/24] usb: phy: nop: Add some parameters to platform data Roger Quadros
2013-03-12 11:43 ` [PATCH 03/24] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes Roger Quadros
2013-03-12 11:43 ` [PATCH 06/24] ARM: OMAP3: 3630SDP: " Roger Quadros
2013-03-12 11:43 ` [PATCH 07/24] ARM: OMAP: AM3517crane: " Roger Quadros
2013-03-12 11:43 ` [PATCH 09/24] ARM: OMAP3: cm-t35: " Roger Quadros
2013-03-12 11:43 ` [PATCH 11/24] ARM: OMAP: devkit8000: " Roger Quadros
2013-03-12 11:43 ` [PATCH 13/24] ARM: OMAP3: omap3evm: " Roger Quadros
[not found] ` <1363088606-2692-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-03-12 11:43 ` [PATCH 02/24] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data Roger Quadros
2013-03-12 11:43 ` [PATCH 04/24] ARM: OMAP3: Beagle: Adapt to ehci-omap changes Roger Quadros
2013-03-12 11:43 ` [PATCH 05/24] ARM: OMAP3: 3430SDP: " Roger Quadros
2013-03-12 11:43 ` [PATCH 08/24] ARM: OMAP: AM3517evm: " Roger Quadros
2013-03-12 11:43 ` [PATCH 10/24] ARM: OMAP3: cm-t3517: " Roger Quadros
2013-03-12 11:43 ` [PATCH 12/24] ARM: OMAP3: igep0020: " Roger Quadros
2013-03-12 11:43 ` [PATCH 14/24] ARM: OMAP3: omap3pandora: " Roger Quadros
2013-03-12 11:43 ` [PATCH 15/24] ARM: OMAP3: omap3stalker: " Roger Quadros
2013-03-12 11:43 ` [PATCH 16/24] ARM: OMAP3: omap3touchbook: " Roger Quadros
2013-03-12 11:43 ` [PATCH 17/24] ARM: OMAP3: overo: " Roger Quadros
2013-03-12 11:43 ` [PATCH 18/24] ARM: OMAP: zoom: " Roger Quadros
2013-03-12 11:43 ` [PATCH 19/24] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-03-12 11:43 ` [PATCH 20/24] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-03-12 11:43 ` [PATCH 21/24] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-03-12 11:43 ` [PATCH 22/24] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-03-12 11:43 ` [PATCH 23/24] ARM: OMAP2+: Allow clock alias provision from device tree Roger Quadros
2013-03-12 13:17 ` Benoit Cousson
[not found] ` <513F2AEB.8070702-l0cyMroinI0@public.gmane.org>
2013-03-12 14:01 ` Roger Quadros
2013-03-12 11:43 ` [PATCH 24/24] ARM: dts: omap4-panda: Add clock alias for USB PHY Roger Quadros
2013-03-12 16:40 ` [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Tony Lindgren
[not found] ` <20130312164007.GZ26093-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-03-13 13:41 ` Roger Quadros
2013-03-13 16:24 ` Tony Lindgren [this message]
2013-03-13 16:36 ` Roger Quadros
2013-03-13 16:57 ` Tony Lindgren
2013-03-14 15:41 ` Roger Quadros
2013-03-14 16:54 ` Tony Lindgren
2013-03-15 9:22 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313162454.GE26093@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).