Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

[Guenter Roeck <linux@roeck-us.net>]

On Wed, Mar 13, 2013 at 01:52:35PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Mar 12, 2013 at 9:08 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
> > This patch adds DT support to NTC driver to parse the
> > platform data.
> >
> > Also adds the support to work as an iio device.
> >
> > During the probe ntc driver gets the respective channels of ADC
> > and uses iio_raw_read calls to get the ADC converted value.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> > ---
> > Changes since v3:
> > 1. Added a NULL check before iio_channel_release
> > 2. Modified a return statement
> >
> > Guenter Roeck, Its wonderful working with you. Thanks.
> >
> >  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   29 ++++
> >  drivers/hwmon/Kconfig                              |    1 +
> >  drivers/hwmon/ntc_thermistor.c                     |  145 +++++++++++++++++---
> >  include/linux/platform_data/ntc_thermistor.h       |    8 +-
> >  4 files changed, 163 insertions(+), 20 deletions(-)
> 
> I haven't done a full review of this code, but it I built it in (along
> with other CLs to enable it on exynos5250-snow) and the thermistors
> are accessible and report reasonable values.
> 
> localhost hwmon # grep "" /sys/class/hwmon/*/device/temp1_input
> /sys/class/hwmon/hwmon0/device/temp1_input:37890
> /sys/class/hwmon/hwmon1/device/temp1_input:38393
> /sys/class/hwmon/hwmon2/device/temp1_input:37148
> /sys/class/hwmon/hwmon3/device/temp1_input:38059
> 
> Tested-by: Doug Anderson <dianders@chromium.org>
> 
Thanks!

Guenter