From: Anatolij Gustschin <agust@denx.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: cjb@laptop.org, rob.herring@calxeda.com, rob@landley.net,
s.hauer@pengutronix.de, linux-mmc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] mmc: mxcmmc: DT support
Date: Thu, 14 Mar 2013 16:50:48 +0100 [thread overview]
Message-ID: <20130314165048.08416241@crub> (raw)
In-Reply-To: <1361816885-3033-1-git-send-email-mpa@pengutronix.de>
On Mon, 25 Feb 2013 19:28:05 +0100
Markus Pargmann <mpa@pengutronix.de> wrote:
> Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic
> gpio helper functions by Guennadi and generic DMA devicetree bindings.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> .../devicetree/bindings/mmc/fsl-imx-mmc.txt | 24 +++++++
> drivers/mmc/host/mxcmmc.c | 80 +++++++++++++++++-----
> 2 files changed, 86 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
> new file mode 100644
> index 0000000..a5ab662
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
> @@ -0,0 +1,24 @@
> +* Freescale Secure Digital Host Controller for i.MX1/2 series
shouldn't it be "... for i.MX2/3 series"?
...
> + if (!host->pdata) {
> + host->dma = of_dma_request_slave_channel(pdev->dev.of_node,
> + "rx-tx");
please use dma_request_slave_channel(&pdev->dev, "rx-tx")
here. of_dma_request_slave_channel() is not exported for
modules, building the driver as a module will fail.
Thanks,
Anatolij
next prev parent reply other threads:[~2013-03-14 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 18:28 [PATCH] mmc: mxcmmc: DT support Markus Pargmann
2013-03-14 15:50 ` Anatolij Gustschin [this message]
2013-03-14 16:35 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314165048.08416241@crub \
--to=agust@denx.de \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).