From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH] mmc: mxcmmc: DT support Date: Thu, 14 Mar 2013 16:50:48 +0100 Message-ID: <20130314165048.08416241@crub> References: <1361816885-3033-1-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361816885-3033-1-git-send-email-mpa@pengutronix.de> Sender: linux-mmc-owner@vger.kernel.org To: Markus Pargmann Cc: cjb@laptop.org, rob.herring@calxeda.com, rob@landley.net, s.hauer@pengutronix.de, linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de List-Id: devicetree@vger.kernel.org On Mon, 25 Feb 2013 19:28:05 +0100 Markus Pargmann wrote: > Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic > gpio helper functions by Guennadi and generic DMA devicetree bindings. > > Signed-off-by: Markus Pargmann > --- > .../devicetree/bindings/mmc/fsl-imx-mmc.txt | 24 +++++++ > drivers/mmc/host/mxcmmc.c | 80 +++++++++++++++++----- > 2 files changed, 86 insertions(+), 18 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt > new file mode 100644 > index 0000000..a5ab662 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt > @@ -0,0 +1,24 @@ > +* Freescale Secure Digital Host Controller for i.MX1/2 series shouldn't it be "... for i.MX2/3 series"? ... > + if (!host->pdata) { > + host->dma = of_dma_request_slave_channel(pdev->dev.of_node, > + "rx-tx"); please use dma_request_slave_channel(&pdev->dev, "rx-tx") here. of_dma_request_slave_channel() is not exported for modules, building the driver as a module will fail. Thanks, Anatolij