* [PATCH] net: fec: make local function fec_poll_controller() static
@ 2013-03-20 15:06 Wei Yongjun
2013-03-20 15:11 ` Li Frank-B20596
2013-03-20 17:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-03-20 15:06 UTC (permalink / raw)
To: grant.likely, rob.herring, davem, Frank.Li, shawn.guo,
fabio.estevam, s.hauer
Cc: yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
fec_poll_controller() was not declared. It should be static.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/freescale/fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index e3f3937..1ece68b 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1559,7 +1559,7 @@ fec_set_mac_address(struct net_device *ndev, void *p)
* Polled functionality used by netconsole and others in non interrupt mode
*
*/
-void fec_poll_controller(struct net_device *dev)
+static void fec_poll_controller(struct net_device *dev)
{
int i;
struct fec_enet_private *fep = netdev_priv(dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] net: fec: make local function fec_poll_controller() static
2013-03-20 15:06 [PATCH] net: fec: make local function fec_poll_controller() static Wei Yongjun
@ 2013-03-20 15:11 ` Li Frank-B20596
2013-03-20 17:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Li Frank-B20596 @ 2013-03-20 15:11 UTC (permalink / raw)
To: Wei Yongjun, grant.likely@secretlab.ca, rob.herring@calxeda.com,
davem@davemloft.net, shawn.guo@linaro.org, Estevam Fabio-R49496,
s.hauer@pengutronix.de
Cc: yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Acked.
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: Wednesday, March 20, 2013 11:06 PM
> To: grant.likely@secretlab.ca; rob.herring@calxeda.com; davem@davemloft.net;
> Li Frank-B20596; shawn.guo@linaro.org; Estevam Fabio-R49496;
> s.hauer@pengutronix.de
> Cc: yongjun_wei@trendmicro.com.cn; netdev@vger.kernel.org; devicetree-
> discuss@lists.ozlabs.org
> Subject: [PATCH] net: fec: make local function fec_poll_controller() static
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> fec_poll_controller() was not declared. It should be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/ethernet/freescale/fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.c
> b/drivers/net/ethernet/freescale/fec.c
> index e3f3937..1ece68b 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -1559,7 +1559,7 @@ fec_set_mac_address(struct net_device *ndev, void *p)
> * Polled functionality used by netconsole and others in non interrupt mode
> *
> */
> -void fec_poll_controller(struct net_device *dev)
> +static void fec_poll_controller(struct net_device *dev)
> {
> int i;
> struct fec_enet_private *fep = netdev_priv(dev);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fec: make local function fec_poll_controller() static
2013-03-20 15:06 [PATCH] net: fec: make local function fec_poll_controller() static Wei Yongjun
2013-03-20 15:11 ` Li Frank-B20596
@ 2013-03-20 17:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-20 17:26 UTC (permalink / raw)
To: weiyj.lk
Cc: grant.likely, rob.herring, Frank.Li, shawn.guo, fabio.estevam,
s.hauer, yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 20 Mar 2013 23:06:11 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> fec_poll_controller() was not declared. It should be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-20 15:06 [PATCH] net: fec: make local function fec_poll_controller() static Wei Yongjun
2013-03-20 15:11 ` Li Frank-B20596
2013-03-20 17:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).