From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support Date: Wed, 20 Mar 2013 02:12:11 +0100 Message-ID: <20130320011211.GA5905@zurbaran> References: <1361830121-32284-1-git-send-email-sjg@chromium.org> <20130320005652.GC26903@zurbaran> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20130320005652.GC26903@zurbaran> Sender: linux-input-owner@vger.kernel.org To: Simon Glass Cc: LKML , Rob Landley , Felipe Balbi , Grant Likely , Wolfram Sang , Luigi Semenzato , Rob Herring , Che-Liang Chiou , Jonathan Kliegman , linux-input@vger.kernel.org, Sourav Poddar , devicetree-discuss@lists.ozlabs.org, Alban Bedel , Roland Stigge , Vincent Palatin , Javier Martinez Canillas , Mark Brown , linux-doc@vger.kernel.org, Dmitry Torokhov , Tony Lindgren , Bill Pemberton List-Id: devicetree@vger.kernel.org On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote: > Hi Simon, >=20 > On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote: > > The ChromeOS Embedded Controller (EC) is an Open Source EC implemen= tation > > used on ARM and Intel Chromebooks. Current implementations use a Co= rtex-M3 > > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate in= terrupt > > line is used to indicate when the EC needs service. > All 6 patches applied to my mfd-next tree, thanks a lot. Actually, this one fails to build when CONFIG_OF is not set: drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of functio= n =E2=80=98of_device_is_available=E2=80=99 [-Werror=3Dimplicit-function-d= eclaration] If the check in cros_ec_probe_i2c() is really needed then you'll need t= o inline of_device_is_available() into a NOP in include/linux/of.h. Cheers, Samuel. --=20 Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html