devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
	linux-mmc@vger.kernel.org, cjb@laptop.org, nsekhar@ti.com,
	grant.likely@secretlab.ca, rob.herring@calxeda.com,
	rob@landley.net, linux@arm.linux.org.uk, hs@denx.de,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, mporter@ti.com
Subject: Re: [PATCH v6 3/5] mmc: davinci_mmc: add DT support
Date: Wed, 20 Mar 2013 13:26:09 +0000	[thread overview]
Message-ID: <201303201326.09265.arnd@arndb.de> (raw)
In-Reply-To: <1363779852-24083-4-git-send-email-prakash.pm@ti.com>

On Wednesday 20 March 2013, Manjunathappa, Prakash wrote:
> Adds device tree support for davinci_mmc. Also add binding documentation.
> As of now in non-dma PIO mode and without GPIO card_detect/write_protect
> option because of dependencies on EDMA and GPIO module DT support.

Shouldn't the binding at least specify the names for the DMA channels?
It's fine if the driver works without those, but I think there is no
strict dependency here: If dma_request_slave_channel does not find
a channel, the driver can just continue in PIO mode, and as soon
as the EDMA driver is merged, it will work with DMA.

	Arnd

  reply	other threads:[~2013-03-20 13:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 11:44 [PATCH v6 0/5] Add DT support for davinci_mmc driver Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 1/5] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 2/5] ARM: davinci: mmc: derive version information from device name Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 3/5] mmc: davinci_mmc: add DT support Manjunathappa, Prakash
2013-03-20 13:26   ` Arnd Bergmann [this message]
2013-03-27  9:55     ` Manjunathappa, Prakash
2013-03-27 10:43       ` Arnd Bergmann
     [not found]         ` <201303271043.51265.arnd-r2nGTMty4D4@public.gmane.org>
2013-03-27 17:46           ` Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 4/5] ARM: davinci: da850: add mmc DT entries Manjunathappa, Prakash
     [not found] ` <1363779852-24083-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-03-20 11:44   ` [PATCH v6 5/5] ARM: davinci: da850: override mmc DT node device name Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303201326.09265.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hs@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mporter@ti.com \
    --cc=nsekhar@ti.com \
    --cc=prakash.pm@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).