From: "Heiko Stübner" <heiko@sntech.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 0/5] move s3c24xx-irq to drivers/irqchip and add dt support
Date: Fri, 22 Mar 2013 22:21:17 +0100 [thread overview]
Message-ID: <201303222221.18605.heiko@sntech.de> (raw)
In-Reply-To: <201303222104.54225.arnd@arndb.de>
Am Freitag, 22. März 2013, 22:04:54 schrieb Arnd Bergmann:
> On Friday 22 March 2013, Heiko Stübner wrote:
> > As suggested by Rob Herring move back to get the parent releationship
> > from dt like in the first versions, but set the handler from the
> > interrupt property rather than from a specific list.
> >
> > This version also implements (hopefully correctly) an idea from him and
> > Arnd Bergmann to have the parent relationship not described in the
> > controller node but the device nodes instead.
> >
> > Therefore the main controller continues to use a two-cell descriptor to
> > set hwirq and trigger type but the sub-controller switches to a
> > three-cell descriptor where the third bit describes the hwirq of its
> > parent irq in the main controller.
> >
> > As a result a serial node would then look like:
> > serial@50000000 {
> >
> > compatible = "samsung,s3c2410-uart";
> > reg = <0x50000000 0x4000>;
> > interrupt-parent = <&subintc>;
> > interrupts = <0 4 28>, <1 4 28>;
> >
> > };
> >
> > Tested on a s3c2416-based board.
> >
> > As it depends on changes already pending for 3.10 it should probably go
> > thru the samsung tree.
>
> Hi Heiko,
>
> I should probably read the original discussion thread again. I already
> commented on the binding here, but I may have missed something important
> that led to it being the way it is now.
Hi Arnd,
Not really ... it's only my current interpretation of your short suggestion to
handle the parent relationship in the interrupt descriptor of the device node
and not in the controller node itself.
Your other mail did contain a lot of interesting thoughts on how to improve
the current state - thanks for them.
Heiko
prev parent reply other threads:[~2013-03-22 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 17:43 [PATCH v4 0/5] move s3c24xx-irq to drivers/irqchip and add dt support Heiko Stübner
2013-03-22 17:44 ` [PATCH v4 1/5] ARM: S3C24XX: move irq driver to drivers/irqchip Heiko Stübner
2013-03-22 17:44 ` [PATCH v4 2/5] irqchip: s3c24xx: fix comments on some camera interrupts Heiko Stübner
2013-03-22 17:45 ` [PATCH v4 3/5] irqchip: s3c24xx: fix irqlist of second s3c2416 controller Heiko Stübner
2013-03-22 17:46 ` [PATCH v4 4/5] irqchip: s3c24xx: add irq_set_type callback for basic interrupt types Heiko Stübner
2013-03-22 17:46 ` [PATCH v4 5/5] irqchip: s3c24xx: add devicetree support Heiko Stübner
2013-03-22 20:55 ` Arnd Bergmann
2013-03-22 22:15 ` Heiko Stübner
2013-03-22 22:42 ` Arnd Bergmann
[not found] ` <201303221843.37668.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-03-22 21:04 ` [PATCH v4 0/5] move s3c24xx-irq to drivers/irqchip and add dt support Arnd Bergmann
2013-03-22 21:21 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303222221.18605.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).