From: Pavel Machek <pavel@denx.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@wwwdotorg.org>,
Marek Vasut <marex@denx.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
kernel@pengutronix.de, devicetree-discuss@lists.ozlabs.org,
Mike Turquette <mturquette@linaro.org>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 0/8] Reset controller API to reset IP modules on i.MX5 and i.MX6
Date: Tue, 26 Mar 2013 19:19:09 +0100 [thread overview]
Message-ID: <20130326181909.GA31593@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1364231189-12497-1-git-send-email-p.zabel@pengutronix.de>
Hi!
> The system reset controller (SRC) on i.MX51, i.MX53, and i.MX6q controls
> reset lines to the GPU, VPU, IPU, and OpenVG IP modules.
>
> The following patches add a simple API for devices to request being reset
> by separate reset controller hardware and implements the reset signal
> device tree binding proposed by Stephen Warren. Contrary to Tegra hardware,
> the i.MX SRC contains self-deasserting reset registers, so I've included
> both ops to manually assert/deassert a reset line, as well as a "reset"
> operation that is supposed to assert the reset line and wait for it to
> deassert.
>
> The i.MX SRC is enhanced to provide a reset controller and the IPU driver
> is made to request being reset by calling the device_reset(&pdev->dev)
> convenience wrapper during probing.
>
> Changes since v4:
> - removed flags parameter from .of_xlate / of_reset_simple_xlate
> - warn also if reset_spec->args_count > rcdev->of_reset_n_cells
> - unlock list mutex only after try_module_get
> - tighten devm_reset_control_match a bit
Series looks mostly ok to me. (Should the last patch be actually
first, so that reset functionality is kept between 5/8 and 8/8?)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-03-26 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 17:06 [PATCH v5 0/8] Reset controller API to reset IP modules on i.MX5 and i.MX6 Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 1/8] dt: describe base reset signal binding Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 2/8] reset: Add reset controller API Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 3/8] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC) Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 4/8] ARM i.MX6q: Link system reset controller (SRC) to IPU in DT Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 5/8] staging: drm/imx: Use SRC to reset IPU Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 6/8] ARM i.MX5: Add System Reset Controller (SRC) support for i.MX51 and i.MX53 Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 7/8] ARM i.MX5: Add system reset controller (SRC) to i.MX51 and i.MX53 device tree Philipp Zabel
2013-03-25 17:06 ` [PATCH v5 8/8] reset: Add driver for gpio-controlled reset pins Philipp Zabel
2013-03-27 12:10 ` Shawn Guo
2013-03-26 18:19 ` Pavel Machek [this message]
[not found] ` <20130326181909.GA31593-tWAi6jLit6GreWDznjuHag@public.gmane.org>
2013-03-26 21:13 ` [PATCH v5 0/8] Reset controller API to reset IP modules on i.MX5 and i.MX6 Marek Vasut
2013-03-27 8:43 ` Philipp Zabel
2013-03-27 12:09 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326181909.GA31593@amd.pavel.ucw.cz \
--to=pavel@denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rjw@sisk.pl \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).