Re: [PATCH v5 0/8] Reset controller API to reset IP modules on i.MX5 and i.MX6

[Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>]

Dear Pavel Machek,

> Hi!
> 
> > The system reset controller (SRC) on i.MX51, i.MX53, and i.MX6q controls
> > reset lines to the GPU, VPU, IPU, and OpenVG IP modules.
> > 
> > The following patches add a simple API for devices to request being reset
> > by separate reset controller hardware and implements the reset signal
> > device tree binding proposed by Stephen Warren. Contrary to Tegra
> > hardware, the i.MX SRC contains self-deasserting reset registers, so
> > I've included both ops to manually assert/deassert a reset line, as well
> > as a "reset" operation that is supposed to assert the reset line and
> > wait for it to deassert.
> > 
> > The i.MX SRC is enhanced to provide a reset controller and the IPU driver
> > is made to request being reset by calling the device_reset(&pdev->dev)
> > convenience wrapper during probing.
> > 
> > Changes since v4:
> >  - removed flags parameter from .of_xlate / of_reset_simple_xlate
> >  - warn also if reset_spec->args_count > rcdev->of_reset_n_cells
> >  - unlock list mutex only after try_module_get
> >  - tighten devm_reset_control_match a bit
> 
> Series looks mostly ok to me. (Should the last patch be actually
> first, so that reset functionality is kept between 5/8 and 8/8?)

Not first, but rather third.

You can add my
Reviewed-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Best regards,
Marek Vasut