From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
"Kukjin Kim" <kgene.kim@samsung.com>,
kyungmin.park@samsung.com, linux@simtec.co.uk,
kwangwoo.lee@gmail.com, jacmet@sunsite.dk,
augulis.darius@gmail.com, mcuelenaere@gmail.com,
linux@arm.linux.org.uk,
"Sylwester Nawrocki" <sylvester.nawrocki@gmail.com>,
buserror@gmail.com, christer@weinigel.se, jekhor@gmail.com,
ghcstop@gmail.com, "Mark Rutland" <mark.rutland@arm.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Rob Herring" <robherring2@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
"Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v3 12/12] clocksource: samsung-time: Add Device Tree support
Date: Thu, 28 Mar 2013 12:30:50 +0000 [thread overview]
Message-ID: <20130328123049.GX18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1362860601-18464-13-git-send-email-tomasz.figa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Sat, Mar 09, 2013 at 09:23:21PM +0100, Tomasz Figa wrote:
> +CLOCKSOURCE_OF_DECLARE(s3c24xx_timer,
> + "samsung,s3c24xx-pwm", samsung_of_timer_init)
> +CLOCKSOURCE_OF_DECLARE(s3c64xx_timer,
> + "samsung,s3c64xx-pwm", samsung_of_timer_init)
This doesn't build for me in a non-OF configuration, though this seems
to be something that CLOCKSOURCE_OF_DECLARE ought to fix rather than
your series - I've sent a patch for that.
It also won't build in an OF configuration with latest -next I think
since commit 4d10f054 (clocksource: make CLOCKSOURCE_OF_DECLARE type
safe) removed the semicolon the macro provided - we need them at the end
of each line here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-28 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362860601-18464-1-git-send-email-tomasz.figa@gmail.com>
2013-03-09 20:23 ` [PATCH v3 12/12] clocksource: samsung-time: Add Device Tree support Tomasz Figa
2013-03-28 12:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328123049.GX18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=augulis.darius@gmail.com \
--cc=buserror@gmail.com \
--cc=christer@weinigel.se \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=ghcstop@gmail.com \
--cc=heiko@sntech.de \
--cc=jacmet@sunsite.dk \
--cc=jekhor@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@simtec.co.uk \
--cc=mark.rutland@arm.com \
--cc=mcuelenaere@gmail.com \
--cc=robherring2@gmail.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).