From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v9 RESEND 4/4] ARM: dts: add sram for imx53 and imx6q Date: Thu, 28 Mar 2013 22:22:08 +0800 Message-ID: <20130328142106.GA699@S2101-09.ap.freescale.net> References: <1363776767-2635-1-git-send-email-p.zabel@pengutronix.de> <1363776767-2635-5-git-send-email-p.zabel@pengutronix.de> <20130328025422.GH5429@S2101-09.ap.freescale.net> <1364461518.4018.4.camel@pizza.hi.pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1364461518.4018.4.camel@pizza.hi.pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Grant Likely , Rob Herring , Paul Gortmaker , Huang Shijie , Dong Aisheng , Matt Porter , Fabio Estevam , Javier Martin , kernel@pengutronix.de, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Thu, Mar 28, 2013 at 10:05:18AM +0100, Philipp Zabel wrote: > > > + > > > + ocram: ocram@f8000000 { > > > + compatible = "fsl,imx-ocram", "mmio-sram"; > > > > We should probably just drop "fsl,imx-ocram". > > > > Shawn > > I thought that in the future somebody might want to implement some i.MX > OCRAM specifics in a different driver, like the L2 cache / OCRAM mode > switching, the timing settings, or the TrustZone bits that are > configurable in the IOMUXC GPR registers. We can add i.MX OCRAM specific compatible when we see that real need. Also, generally we should use a specific chip/osc name rather than "imx" for compatible to specify the particular hardware version. Shawn