From: Jan Luebbe <jlu@pengutronix.de>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
b-cousson@ti.com, benoit.cousson@linaro.org, tony@atomide.com
Subject: Re: [PATCH 1/3] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone
Date: Mon, 1 Apr 2013 12:45:14 +0200 [thread overview]
Message-ID: <20130401104514.GA27388@pengutronix.de> (raw)
In-Reply-To: <1364196478-16688-2-git-send-email-mugunthanvnm@ti.com>
On Mon, Mar 25, 2013 at 12:57:56PM +0530, Mugunthan V N wrote:
> am33xx_pinmux: pinmux@44e10800 {
> pinctrl-names = "default";
> - pinctrl-0 = <&user_leds_s0>;
> + pinctrl-0 = <&user_leds_s0 &cpsw_s0>;
Why do you add &cpsw_s0 to the pinmux node? This should go into the cpsw
node itself, which should work without further code changes since:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ab78029ecc347
(drivers/pinctrl: grab default handles from device core)
Same for the other patches.
Regards,
Jan
next prev parent reply other threads:[~2013-04-01 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 7:27 [PATCH 0/3] add pin-mux configuration for AM33xx CPSW Mugunthan V N
2013-03-25 7:27 ` [PATCH 1/3] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone Mugunthan V N
2013-04-01 10:45 ` Jan Luebbe [this message]
2013-03-25 7:27 ` [PATCH 2/3] ARM: dts: AM33XX: Add pinmux configuration for CPSW to EVMsk Mugunthan V N
2013-03-25 7:27 ` [PATCH 3/3] ARM: dts: AM33XX: Add pinmux configuration for CPSW to am335x EVM Mugunthan V N
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 11:32 [PATCH 0/3] Add pinmux DT nodes to CPSW for AM335x Mugunthan V N
2013-06-07 11:32 ` [PATCH 1/3] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401104514.GA27388@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=b-cousson@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).