From: Sascha Hauer <s.hauer@pengutronix.de>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Markus Pargmann <mpa@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2 4/5] mmc: mxcmmc: enable DMA support on mpc512x
Date: Tue, 2 Apr 2013 09:48:17 +0200 [thread overview]
Message-ID: <20130402074817.GK1906@pengutronix.de> (raw)
In-Reply-To: <20130402092944.387d6561@crub>
On Tue, Apr 02, 2013 at 09:29:44AM +0200, Anatolij Gustschin wrote:
> On Tue, 2 Apr 2013 08:56:54 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> ...
> > > @@ -336,6 +359,8 @@ static int mxcmci_setup_data(struct mxcmci_host *host, struct mmc_data *data)
> > > } else {
> > > host->dma_dir = DMA_TO_DEVICE;
> > > slave_dirn = DMA_MEM_TO_DEV;
> > > +
> > > + mxcmci_fixup_buffers(data);
> >
> > For the register accesses it's fine the way you did in this version, but
> > here I think a
> >
> > if (is_mpc512x_mmc())
> > swap_buffer()
> >
> > would look better.
>
> the swapping function uses optimised st_le32() which is not available
> on ARM, that's the reason why this is build time selected.
Ah, ok. I think it's fine then.
> Maybe the
> "fixup" in the function name is not pretty, I can change it to "swap"
> then.
Yes, that would be better.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-04-02 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 22:23 [PATCH v2 0/5] mmc: mxcmmc: add mpc512x support Anatolij Gustschin
2013-03-31 22:23 ` [PATCH v2 1/5] mmc: mxcmmc: add mpc512x SDHC support Anatolij Gustschin
2013-03-31 22:23 ` [PATCH v2 2/5] mmc: mxcmmc: use slot-gpio API for write-protect detection Anatolij Gustschin
2013-03-31 22:23 ` [PATCH v2 3/5] mmc: mxcmmc: constify mxcmci_devtype Anatolij Gustschin
2013-03-31 22:23 ` [PATCH v2 4/5] mmc: mxcmmc: enable DMA support on mpc512x Anatolij Gustschin
2013-04-02 6:56 ` Sascha Hauer
2013-04-02 7:29 ` Anatolij Gustschin
2013-04-02 7:48 ` Sascha Hauer [this message]
2013-03-31 22:23 ` [PATCH v2 5/5] mmc: mxcmmc: fix race conditions for host->req and host->data access Anatolij Gustschin
2013-04-02 6:58 ` Sascha Hauer
2013-04-02 7:01 ` [PATCH v2 0/5] mmc: mxcmmc: add mpc512x support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402074817.GK1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=agust@denx.de \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).