From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>, Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Grant Likely <grant.likely@secretlab.ca>,
Russell King <linux@arm.linux.org.uk>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Olof Johansson <olof@lixom.net>,
linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Thierry Reding <thierry.reding@avionic-design.de>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Maen Suleiman <maen@marvell.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Andrew Murray <andrew.murray@arm.com>,
Tawfik Bayouk <tawfik@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Mitch Bradley <wmb@firmworks.com>
Subject: Re: [RFC PATCHv1 2/5] bus: mvebu: fix mistake in PCIe window target attribute for Kirkwood
Date: Wed, 3 Apr 2013 12:52:47 +0200 [thread overview]
Message-ID: <20130403125247.5914a862@skate> (raw)
In-Reply-To: <1364407504-13524-3-git-send-email-thomas.petazzoni@free-electrons.com>
Jason (Cooper),
Do you mind taking this patch in your mvebu/drivers branch, next to the
patch adding the mvebu-mbus driver? Or do you want a new mvebu-mbus
driver patch that contains this fix and would replace the one you have
already merged in mvebu/drivers?
Thanks!
Thomas
On Wed, 27 Mar 2013 19:05:01 +0100, Thomas Petazzoni wrote:
> The target and attributes for the PCIe address decoding windows were
> not correct on Kirkwood for the second PCIe interface.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Note: this patch should be merged with the existing mvebu-mbus driver.
> ---
> drivers/bus/mvebu-mbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
> index 586d03e..4de2c6b 100644
> --- a/drivers/bus/mvebu-mbus.c
> +++ b/drivers/bus/mvebu-mbus.c
> @@ -626,7 +626,7 @@ static const struct mvebu_mbus_soc_data armada_xp_mbus_data = {
>
> static const struct mvebu_mbus_mapping kirkwood_map[] = {
> MAPDEF("pcie0.0", 4, 0xe0, MAPDEF_PCIMASK),
> - MAPDEF("pcie1.0", 8, 0xe0, MAPDEF_PCIMASK),
> + MAPDEF("pcie1.0", 4, 0xd0, MAPDEF_PCIMASK),
> MAPDEF("sram", 3, 0x01, MAPDEF_NOMASK),
> MAPDEF("nand", 1, 0x2f, MAPDEF_NOMASK),
> {},
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-04-03 10:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 18:04 [RFC PATCHv1 0/5] Use the mvebu PCIe driver on Kirkwood Thomas Petazzoni
2013-03-27 18:05 ` [RFC PATCHv1 1/5] pci: mvebu: enable driver usage " Thomas Petazzoni
2013-03-27 18:05 ` [RFC PATCHv1 2/5] bus: mvebu: fix mistake in PCIe window target attribute for Kirkwood Thomas Petazzoni
2013-04-03 10:52 ` Thomas Petazzoni [this message]
2013-04-03 10:57 ` Jason Cooper
2013-04-03 11:05 ` Thomas Petazzoni
2013-03-27 18:05 ` [RFC PATCHv1 3/5] arm: mach-kirkwood: seperate PCIe window init from other windows Thomas Petazzoni
2013-03-27 18:35 ` Jason Gunthorpe
2013-03-27 20:17 ` Thomas Petazzoni
2013-03-27 18:05 ` [RFC PATCHv1 4/5] arm: kirkwood: add SoC-level Device Tree data for PCIe interfaces Thomas Petazzoni
2013-03-27 18:05 ` [RFC PATCHv1 5/5] arm: kirkwood: convert db-88f6281 to the Device Tree Thomas Petazzoni
2013-03-27 18:07 ` [RFC PATCHv1 0/5] Use the mvebu PCIe driver on Kirkwood Arnd Bergmann
2013-03-27 18:11 ` Thomas Petazzoni
2013-03-27 18:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403125247.5914a862@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew.murray@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=olof@lixom.net \
--cc=tawfik@marvell.com \
--cc=thierry.reding@avionic-design.de \
--cc=wmb@firmworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox