From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomasz Figa <t.figa@samsung.com>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
lrg@ti.com, myungjoo.ham@samsung.com, kgene.kim@samsung.com
Subject: Re: [PATCH 2/2] regulator: max8952: Add Device Tree support
Date: Fri, 5 Apr 2013 11:22:21 +0100 [thread overview]
Message-ID: <20130405102221.GE6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365092240-8956-3-git-send-email-t.figa@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Thu, Apr 04, 2013 at 06:17:20PM +0200, Tomasz Figa wrote:
> + if (of_property_read_u32(np, "max8952,ramp-speed", &pd->ramp_speed))
> + dev_warn(dev, "max8952,ramp-speed property not specified, defaulting to 32mV/us\n");
Applied both, though the above warning seems a bit harsh - it seems like
assuming a worst case ramp rate ought to be totally safe and just a
minor performance issue so silently accepted.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-04-05 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 16:17 [PATCH 0/2] regulator: max8952: Add support for Device Tree Tomasz Figa
2013-04-04 16:17 ` [PATCH 1/2] regulator: max8952: Separate constraints from platform data struct Tomasz Figa
2013-04-04 16:17 ` [PATCH 2/2] regulator: max8952: Add Device Tree support Tomasz Figa
2013-04-05 10:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405102221.GE6597@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).