From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 3/8] die: constify format string arg
Date: Mon, 8 Apr 2013 19:43:21 +1000 [thread overview]
Message-ID: <20130408094321.GK17787@truffula.fritz.box> (raw)
In-Reply-To: <1365404812-15153-4-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 985 bytes --]
On Mon, Apr 08, 2013 at 03:06:47AM -0400, Mike Frysinger wrote:
> We only display this string, so there's no need for it to be writable.
> Constify away!
>
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> ---
> util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util.h b/util.h
> index 3c20b15..d856eb9 100644
> --- a/util.h
> +++ b/util.h
> @@ -23,7 +23,7 @@
> * USA
> */
>
> -static inline void __attribute__((noreturn)) die(char * str, ...)
> +static inline void __attribute__((noreturn)) die(const char *str, ...)
> {
> va_list ap;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-04-08 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 7:06 [PATCH 0/8] usage()/--help clean up & unification Mike Frysinger
[not found] ` <1365404812-15153-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-08 7:06 ` [PATCH 1/8] utilfdt_read_err: use xmalloc funcs Mike Frysinger
[not found] ` <1365404812-15153-2-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-08 9:42 ` David Gibson
2013-04-08 7:06 ` [PATCH 2/8] utilfdt_read: pass back up the length of data read Mike Frysinger
2013-04-08 7:06 ` [PATCH 3/8] die: constify format string arg Mike Frysinger
[not found] ` <1365404812-15153-4-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-08 9:43 ` David Gibson [this message]
2013-04-08 7:06 ` [PATCH 4/8] util_version: new helper for displaying version info Mike Frysinger
[not found] ` <1365404812-15153-5-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-09 0:01 ` David Gibson
2013-04-08 7:06 ` [PATCH 5/8] fdtdump: make usage a bit more friendly Mike Frysinger
2013-04-08 7:06 ` [PATCH 6/8] fdtdump: add a --scan option Mike Frysinger
2013-04-08 7:06 ` [PATCH 7/8] dtc/fdt{get, put}/convert-dtsv0-lexer: convert to new usage helpers Mike Frysinger
2013-04-08 7:06 ` [PATCH 8/8] util: drop "long" from " Mike Frysinger
2013-04-08 8:53 ` [PATCH 0/8] usage()/--help clean up & unification Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408094321.GK17787@truffula.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).