From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH 3/8] die: constify format string arg Date: Mon, 8 Apr 2013 19:43:21 +1000 Message-ID: <20130408094321.GK17787@truffula.fritz.box> References: <1365404812-15153-1-git-send-email-vapier@gentoo.org> <1365404812-15153-4-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7797983821255525133==" Return-path: In-Reply-To: <1365404812-15153-4-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mike Frysinger Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org --===============7797983821255525133== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEfPc/DjvCj+JzNg" Content-Disposition: inline --PEfPc/DjvCj+JzNg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2013 at 03:06:47AM -0400, Mike Frysinger wrote: > We only display this string, so there's no need for it to be writable. > Constify away! >=20 > Signed-off-by: Mike Frysinger Acked-by: David Gibson > --- > util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/util.h b/util.h > index 3c20b15..d856eb9 100644 > --- a/util.h > +++ b/util.h > @@ -23,7 +23,7 @@ > * USA > */ > =20 > -static inline void __attribute__((noreturn)) die(char * str, ...) > +static inline void __attribute__((noreturn)) die(const char *str, ...) > { > va_list ap; > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --PEfPc/DjvCj+JzNg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlFikTkACgkQaILKxv3ab8YjGACfbJ7OEhrxjSSE0Lz1kN3lPXV2 /y0An3DcvkZXF5HN6/HDoob7pJxrTUuw =99ub -----END PGP SIGNATURE----- --PEfPc/DjvCj+JzNg-- --===============7797983821255525133== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============7797983821255525133==--