From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH 1/2] dmaengine: mpc512x_dma: use generic DMA DT bindings Date: Tue, 9 Apr 2013 13:42:36 +0200 Message-ID: <20130409134236.4d1bffa6@crub> References: <1364746680-6564-1-git-send-email-agust@denx.de> <5162A017.8010102@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5162A017.8010102@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org To: Lars-Peter Clausen Cc: Vinod Koul , linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Mon, 08 Apr 2013 12:46:47 +0200 Lars-Peter Clausen wrote: ... > > +static struct dma_chan *mpc_dma_xlate(struct of_phandle_args *dma_spec, > > + struct of_dma *ofdma) > > +{ > > + int count = dma_spec->args_count; > > + struct mpc_dma *mdma = ofdma->of_dma_data; > > + struct mpc_dma_filter_args fargs; > > + dma_cap_mask_t cap; > > + > > + if (!mdma) > > + return NULL; > > + > > + if (count != 1) > > + return NULL; > > + > > + fargs.mdma = mdma; > > + fargs.chan_id = dma_spec->args[0]; > > + > > + dma_cap_zero(cap); > > + dma_cap_set(DMA_SLAVE, cap); > > + > > + return dma_request_channel(cap, mpc_dma_filter, &fargs); > > +} > > + > > This is more or less the same as the generic of_dma_xlate_by_chan_id > function I posted about two weeks ago: > https://patchwork.kernel.org/patch/2331091/ Thanks. I can use the generic of_dma_xlate_by_chan_id() when above patch will be accepted. Anatolij