From: Markus Pargmann <mpa@pengutronix.de>
To: Timur Tabi <timur@tabi.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/11] ASoC: fsl-ssi: imx ac97 support
Date: Wed, 10 Apr 2013 13:33:04 +0200 [thread overview]
Message-ID: <20130410113304.GB16749@pengutronix.de> (raw)
In-Reply-To: <5162301F.9090000@tabi.org>
On Sun, Apr 07, 2013 at 09:49:03PM -0500, Timur Tabi wrote:
> Markus Pargmann wrote:
> >This patch copies some parts from imx-ssi to support AC97 on
> >imx27-pca100 and imx27-pcm043. It is activated with a new fsl,imx-ac97
> >bool property. It was tested on imx27-pca100.
>
> I'm not crazy about this patch -- it seems a bit hackish. There are
> too many "if (imx_ac97)" clauses. Large pieces of code that don't
> appear to be related to AC97 are indented in an if-clause. I
> especially don't like the "If we use AC97, the registers are already
> setup correctly".
>
I will try to seperate it a little bit cleaner by using different dai
ops for ac97 for the two big ifs and perhaps use a seperated register
setup function so it can be used from ssi startup and ac97_setup.
Regards,
Markus
> --
> Timur Tabi
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-04-10 11:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 19:25 [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 02/11] ASoC: imx-pcm-dma: Add support for DMA init by device node Markus Pargmann
[not found] ` <1365362721-3731-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-04-07 19:25 ` [PATCH v2 01/11] ASoC: phycore-ac97: Add DT support Markus Pargmann
2013-04-08 2:52 ` Timur Tabi
2013-04-10 11:03 ` Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 03/11] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 04/11] ASoC: fsl-ssi: Add SACNT definitions Markus Pargmann
2013-04-08 0:13 ` Timur Tabi
2013-04-07 19:25 ` [PATCH v2 05/11] ASoC: fsl-ssi: Add support for imx-pcm-fiq Markus Pargmann
2013-04-08 0:18 ` Timur Tabi
[not found] ` <51620CEA.3010703-N01EOCouUvQ@public.gmane.org>
2013-04-14 10:38 ` Markus Pargmann
2013-04-14 13:37 ` Timur Tabi
2013-04-14 14:10 ` Markus Pargmann
2013-04-14 14:53 ` Timur Tabi
[not found] ` <516AC305.2000800-N01EOCouUvQ@public.gmane.org>
2013-04-14 15:20 ` Markus Pargmann
2013-04-14 15:25 ` Timur Tabi
2013-04-14 15:44 ` Markus Pargmann
2013-04-15 16:15 ` Mark Brown
2013-04-07 19:25 ` [PATCH v2 06/11] ASoC: fsl-ssi: Setup generic imx dma params Markus Pargmann
2013-04-08 2:50 ` Timur Tabi
2013-04-13 13:52 ` Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 07/11] ARM: imx: Export ac97 reset functions Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 08/11] ASoC: fsl-ssi: imx ac97 support Markus Pargmann
2013-04-08 2:49 ` Timur Tabi
2013-04-10 11:33 ` Markus Pargmann [this message]
2013-04-07 19:25 ` [PATCH v2 09/11] ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 11/11] ASoC: fsl: Update fsl-ssi binding doc Markus Pargmann
2013-04-07 19:25 ` [PATCH v2 10/11] ASoC: fsl: Move fsl-ssi binding doc to sound/ Markus Pargmann
2013-04-08 0:20 ` Timur Tabi
2013-04-07 19:39 ` [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support Lars-Peter Clausen
2013-04-07 20:08 ` Markus Pargmann
[not found] ` <20130407200843.GA8350-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-04-07 20:35 ` [alsa-devel] " Lars-Peter Clausen
2013-04-13 13:32 ` Markus Pargmann
2013-04-13 13:40 ` Lars-Peter Clausen
[not found] ` <51696034.6060709-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-04-13 13:55 ` [alsa-devel] " Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410113304.GB16749@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).