From: Tony Lindgren <tony@atomide.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Stephen Warren <swarren@nvidia.com>,
linus.walleij@linaro.org, Peter Ujfalusi <peter.ujfalusi@ti.com>,
Prabhakar Lad <prabhakar.csengg@gmail.com>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: Query on pinctrl usage for DT nodes
Date: Wed, 10 Apr 2013 13:34:09 -0700 [thread overview]
Message-ID: <20130410203408.GP10155@atomide.com> (raw)
In-Reply-To: <5165A22B.4070200@wwwdotorg.org>
* Stephen Warren <swarren@wwwdotorg.org> [130410 10:37]:
> On 04/10/2013 02:12 AM, Prabhakar Lad wrote:
> ...
> > Following is the proposed fix/hack let me know if its OK.
> >
> > Regards,
> > --Prabhakar
> >
> > ->>>>>>>>>>>>>>>>>>>
> >
> > diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h
> > index ee72f1f..78fb42d 100644
> > --- a/drivers/pinctrl/core.h
> > +++ b/drivers/pinctrl/core.h
> > @@ -46,6 +46,7 @@ struct pinctrl_dev {
> > struct pinctrl *p;
> > struct pinctrl_state *hog_default;
> > struct pinctrl_state *hog_sleep;
> > + bool bits_per_mux;
>
> This clearly isn't correct; any change to solve this problem should only
> touch the internals of the pinctrl-single driver, not the pinctrl core.
Yeah how about just change the pintctrl-single,bits register
naming to be register + bit? Something like 0xdeadbeef.0 and
0xdeadbeef.1 and so on.
Regards,
Tony
next prev parent reply other threads:[~2013-04-10 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:16 Query on pinctrl usage for DT nodes Prabhakar Lad
[not found] ` <CA+V-a8uiPwsAD--OHFAE=i2ed+-wbXm4p2deZXr92+Zv6GDS1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-03 16:44 ` Stephen Warren
[not found] ` <515C5C76.3080009-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-03 18:38 ` Tony Lindgren
[not found] ` <20130403183803.GA10155-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-04-03 18:42 ` Tony Lindgren
2013-04-15 8:19 ` Peter Ujfalusi
[not found] ` <516BB818.3060603-l0cyMroinI0@public.gmane.org>
2013-04-15 16:40 ` Stephen Warren
2013-04-16 7:18 ` Peter Ujfalusi
2013-04-08 13:12 ` Prabhakar Lad
[not found] ` <CA+V-a8t3wtP77DdeUoQHKMjAuWmV+ude+1J3UjJmMTqobgStjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-08 17:24 ` Stephen Warren
2013-04-10 8:12 ` Prabhakar Lad
2013-04-10 17:32 ` Stephen Warren
2013-04-10 20:34 ` Tony Lindgren [this message]
2013-04-15 5:09 ` Prabhakar Lad
2013-04-15 6:42 ` Prabhakar Lad
2013-04-15 8:26 ` Peter Ujfalusi
[not found] ` <516BB99F.2080502-l0cyMroinI0@public.gmane.org>
2013-04-16 21:32 ` Tony Lindgren
2013-04-23 7:42 ` Peter Ujfalusi
[not found] ` <51763B7B.707-l0cyMroinI0@public.gmane.org>
2013-04-23 18:17 ` Tony Lindgren
[not found] ` <20130423181753.GK10155-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-05-21 14:16 ` Manjunathappa, Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410203408.GP10155@atomide.com \
--to=tony@atomide.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peter.ujfalusi@ti.com \
--cc=prabhakar.csengg@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).