From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Query on pinctrl usage for DT nodes Date: Wed, 10 Apr 2013 13:34:09 -0700 Message-ID: <20130410203408.GP10155@atomide.com> References: <515C5C76.3080009@wwwdotorg.org> <5162FD4A.1030909@wwwdotorg.org> <5165A22B.4070200@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5165A22B.4070200@wwwdotorg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stephen Warren Cc: Stephen Warren , linus.walleij@linaro.org, Peter Ujfalusi , Prabhakar Lad , device-tree , LAK List-Id: devicetree@vger.kernel.org * Stephen Warren [130410 10:37]: > On 04/10/2013 02:12 AM, Prabhakar Lad wrote: > ... > > Following is the proposed fix/hack let me know if its OK. > > > > Regards, > > --Prabhakar > > > > ->>>>>>>>>>>>>>>>>>> > > > > diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h > > index ee72f1f..78fb42d 100644 > > --- a/drivers/pinctrl/core.h > > +++ b/drivers/pinctrl/core.h > > @@ -46,6 +46,7 @@ struct pinctrl_dev { > > struct pinctrl *p; > > struct pinctrl_state *hog_default; > > struct pinctrl_state *hog_sleep; > > + bool bits_per_mux; > > This clearly isn't correct; any change to solve this problem should only > touch the internals of the pinctrl-single driver, not the pinctrl core. Yeah how about just change the pintctrl-single,bits register naming to be register + bit? Something like 0xdeadbeef.0 and 0xdeadbeef.1 and so on. Regards, Tony