Re: [PATCH 06/10] fdtdump: add a --scan option

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --]

On Wed, Apr 10, 2013 at 02:29:11PM -0400, Mike Frysinger wrote:
> Often times, fdts get embedded in other larger files.  Rather than force
> people to `dd` the blob out themselves, make the fdtdump file smarter.
> 
> It can now scan the blob looking for the fdt magic.  Once locate, it does
> a little validation on the main struct to make sure we didn't hit random
> binary data.
> 
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

Hrm.  I have mixed feelings about this.  The scanning functionality is
certainly useful.  But on the other hand, fdtdump is not supposed to
be a general use tool.  It's basically a debugging aid: a quick and
dirty independent implementation of a dtb dump, for checking that dtc
is producing sane output.  The preferred way to dump dtbs "for real"
is to use dtc -I dtb -O dts

I think the way I'd prefer to see this functionality would be to add a
new input format to dtc which is a little wrapper around the dtb input
format which does the scan.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss