From: Andrew Murray <andrew.murray@arm.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "jg1.han@samsung.com" <jg1.han@samsung.com>,
"monstr@monstr.eu" <monstr@monstr.eu>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"arnd@arndb.de" <arnd@arndb.de>,
"siva.kallam@samsung.com" <siva.kallam@samsung.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"thierry.reding@avionic-design.de"
<thierry.reding@avionic-design.de>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"paulus@samba.org" <paulus@samba.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"bhelgaas@google.com" <bhelgaa>
Subject: Re: [PATCH v5 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC
Date: Thu, 11 Apr 2013 13:12:42 +0100 [thread overview]
Message-ID: <20130411121242.GB28981@arm.com> (raw)
In-Reply-To: <20130410233330.4e9479b0@skate>
On Wed, Apr 10, 2013 at 10:33:30PM +0100, Thomas Petazzoni wrote:
> Dear Andrew Murray,
>
> On Wed, 10 Apr 2013 08:29:26 +0100, Andrew Murray wrote:
>
> > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
> > index bb115de..6852481 100644
> > --- a/include/linux/of_pci.h
> > +++ b/include/linux/of_pci.h
> > @@ -11,4 +11,7 @@ struct device_node;
> > struct device_node *of_pci_find_child_device(struct device_node *parent,
> > unsigned int devfn);
> >
> > +void pci_process_bridge_OF_ranges(struct pci_controller *hose,
> > + struct device_node *dev, int primary);
> > +
> > #endif
>
> In this file, 'struct pci_controller' is not defined anywhere, and not
> in any header file that is included. So I get a warning at compile time
> when <linux/of_pci.h> is included, but nothing has defined 'struct
> pci_controller' beforehand. So I think this file should carry a change
> like:
>
> +struct pci_controller;
>
> In my version of the patch I added it, see:
>
> diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
> index bb115de..e56182f 100644
> --- a/include/linux/of_pci.h
> +++ b/include/linux/of_pci.h
> @@ -4,6 +4,7 @@
> #include <linux/pci.h>
>
> struct pci_dev;
> +struct pci_controller;
> struct of_irq;
> int of_irq_map_pci(const struct pci_dev *pdev, struct of_irq *out_irq);
>
> @@ -11,4 +12,7 @@ struct device_node;
> struct device_node *of_pci_find_child_device(struct device_node *parent,
> unsigned int devfn);
>
> +void pci_process_bridge_OF_ranges(struct pci_controller *hose,
> + struct device_node *dev, int primary);
> +
> #endif
>
> But otherwise, for PATCH 1/3 and 2/3,
Thanks - I somehow missed this.
I've included this change in my next respin - but I've put
'struct pci_controller' immediately before 'pci_process_bridge_OF_ranges'
rather than above of_irq_map_pci to be consistent with the rest of the file.
Andrew Murray
>
> Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
next prev parent reply other threads:[~2013-04-11 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 7:29 [PATCH v5 0/3] of/pci: Provide common support for PCI DT parsing Andrew Murray
[not found] ` <1365578969-30966-1-git-send-email-Andrew.Murray-5wv7dgnIgG8@public.gmane.org>
2013-04-10 7:29 ` [PATCH v5 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC Andrew Murray
2013-04-10 13:13 ` Rob Herring
2013-04-10 21:30 ` Thomas Petazzoni
2013-04-11 16:57 ` Linus Walleij
[not found] ` <51656592.7070806-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-11 12:03 ` Andrew Murray
2013-04-10 21:33 ` Thomas Petazzoni
2013-04-11 12:12 ` Andrew Murray [this message]
[not found] ` <20130411121242.GB28981-5wv7dgnIgG8@public.gmane.org>
2013-04-11 15:28 ` Thomas Petazzoni
2013-04-10 7:29 ` [PATCH v5 2/3] of/pci: Provide support for parsing PCI DT ranges property Andrew Murray
[not found] ` <1365578969-30966-3-git-send-email-Andrew.Murray-5wv7dgnIgG8@public.gmane.org>
2013-04-10 18:26 ` Rob Herring
[not found] ` <5165AEBA.7000803-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-11 13:11 ` Andrew Murray
2013-04-10 7:29 ` [PATCH v5 3/3] of/pci: mips: convert to common of_pci_range_parser Andrew Murray
2013-04-10 18:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411121242.GB28981@arm.com \
--to=andrew.murray@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=rob.herring@calxeda.com \
--cc=siva.kallam@samsung.com \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).