From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Pargmann Subject: Re: [PATCH v2 05/11] ASoC: fsl-ssi: Add support for imx-pcm-fiq Date: Sun, 14 Apr 2013 17:44:56 +0200 Message-ID: <20130414154456.GF27394@pengutronix.de> References: <1365362721-3731-1-git-send-email-mpa@pengutronix.de> <1365362721-3731-6-git-send-email-mpa@pengutronix.de> <51620CEA.3010703@tabi.org> <20130414103819.GA27394@pengutronix.de> <516AB111.3000007@tabi.org> <20130414141015.GC27394@pengutronix.de> <516AC305.2000800@tabi.org> <20130414152016.GE27394@pengutronix.de> <516ACA7D.60807@tabi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <516ACA7D.60807@tabi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Timur Tabi Cc: Fabio Estevam , alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, Mark Brown , Liam Girdwood , Grant Likely , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Sun, Apr 14, 2013 at 10:25:49AM -0500, Timur Tabi wrote: > Markus Pargmann wrote: > >I only ported the imx-ssi ac97 driver code and tested twice using DMA > >without success. But there is a good description of the problem in > >imx-ssi: > > > >" The WM9712 with which this driver > >was developed with always sends GPIO status data in slot 12 which > >we receive in our (PCM-) data stream. The only chance we have is to > >manually skip this data in the FIQ handler." > > Ah, so this is a work-around for a bug, where the codec is > incompatible with the SoC? Mark, are you familiar with this issue? > Is there a way to reconfigure the codec so that it works better with > the SoC? It seems ridiculous to add all this code just because an > incompatible codec was chosen for some board. > > Either way, the board DTS needs to clearly state *why* we're > enabling FIQ mode when DMA mode should work. And the patch that > adds FIQ support needs to say that it's for boards with broken DMA > support. Okay, I will add those comments to the commit message, binding documentation and add parts of the imx-ssi problem description to fsl-ssi. Regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |