devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Christoph Fritz" <chf.fritz@googlemail.com>,
	"Javier Martinez Canillas" <martinez.javier@gmail.com>,
	"Liam Girdwood" <lrg@ti.com>, "Benoît Cousson" <b-cousson@ti.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	devicetree-discuss@lists.ozlabs.org,
	"Daniel Mack" <daniel@zonque.org>,
	"Hans J. Koch" <hjk@hansjkoch.de>
Subject: Re: [BUG] omap: mfd/regulator: twl/core: init order
Date: Mon, 15 Apr 2013 09:25:42 -0700	[thread overview]
Message-ID: <20130415162541.GO10155@atomide.com> (raw)
In-Reply-To: <516BDDAC.8040905@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [130415 04:05]:
> On 04/15/2013 01:56 PM, Christoph Fritz wrote:
> >On Mon, 2013-04-15 at 13:20 +0300, Grygorii Strashko wrote:
> >>--- a/drivers/pinctrl/pinctrl-single.c
> >>+++ b/drivers/pinctrl/pinctrl-single.c
> >>@@ -1014,7 +1014,18 @@ static struct platform_driver pcs_driver = {
> >>          },
> >>   };
> >>
> >>-module_platform_driver(pcs_driver);
> >>+static int __init pcs_driver_drv_init(void)
> >>+{
> >>+       return platform_driver_register(&pcs_driver);
> >>+}
> >>+postcore_initcall(pcs_driver_drv_init);
> >>+
> >>+static void __exit pcs_driver_drv_exit(void)
> >>+{
> >>+       platform_driver_unregister(&pcs_driver);
> >>+}
> >>+module_exit(pcs_driver_drv_exit);
> >>+
> >Hi Grygorii,
> >  thanks - indeed it does fix the problem. I checked at least the rtc
> >which is now configured right and working :-)
> >
> >Do you consider the patch above as a hack or will it go mainline?
> I think, need more opinions on this from community )
> I'm just trying to solve my problem and found similar issue.

This fix should not be needed. It just means the real
problem is somewhere else. Pinctrl is already before the i2c
in drivers/Makefile. Maybe one of the MFD drivers has
a wrong initcall level?

Regards,

Tony

  reply	other threads:[~2013-04-15 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 18:27 [BUG] omap: mfd/regulator: twl/core: init order Christoph Fritz
2013-04-15 10:20 ` Grygorii Strashko
2013-04-15 10:56   ` Christoph Fritz
2013-04-15 10:59     ` Grygorii Strashko
2013-04-15 16:25       ` Tony Lindgren [this message]
     [not found]         ` <20130415162541.GO10155-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-04-16  7:45           ` Peter Ujfalusi
2013-04-16  8:33             ` Grygorii Strashko
2013-04-16 17:54               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415162541.GO10155@atomide.com \
    --to=tony@atomide.com \
    --cc=a.zummo@towertech.it \
    --cc=b-cousson@ti.com \
    --cc=chf.fritz@googlemail.com \
    --cc=daniel@zonque.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grygorii.strashko@ti.com \
    --cc=hjk@hansjkoch.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=martinez.javier@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).