devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Peter Ujfalusi" <peter.ujfalusi@ti.com>,
	"Christoph Fritz" <chf.fritz@googlemail.com>,
	"Javier Martinez Canillas" <martinez.javier@gmail.com>,
	"Benoît Cousson" <b-cousson@ti.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	devicetree-discuss@lists.ozlabs.org,
	"Daniel Mack" <daniel@zonque.org>,
	"Hans J. Koch" <hjk@hansjkoch.de>
Subject: Re: [BUG] omap: mfd/regulator: twl/core: init order
Date: Tue, 16 Apr 2013 10:54:39 -0700	[thread overview]
Message-ID: <20130416175438.GR10155@atomide.com> (raw)
In-Reply-To: <516D0CEC.2060306@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [130416 01:39]:
> On 04/16/2013 10:45 AM, Peter Ujfalusi wrote:
> >On 04/15/2013 06:25 PM, Tony Lindgren wrote:
> >>This fix should not be needed. It just means the real
> >>problem is somewhere else. Pinctrl is already before the i2c
> >>in drivers/Makefile. Maybe one of the MFD drivers has
> >>a wrong initcall level?
> >FYI; I just sent a patch which I believe is the correct way to fix this issue.
> >
> Hi Tony, Peter
> 
> OMAP i2c/pin-control initialization isn't controlled by Makefiles now (:
> - i2c initialized at subsys_initcall(omap_i2c_init_driver);

AFAIK there should be no reason to have this as subsys_initcall
any longer. It should be just regular module init.

> - pinctrl-single at module_platform_driver(pcs_driver) =>
> module_init => device_initcall (if built-in)

Yes but still, the deferred probe should handle this case too,
I wonder why we're not seeing this issue on omap4 for example?
 
> And pls, pay attention on overall BUG description - twl-regulators
> initialization has been delayed as result all Regulators consumers
> (drivers which use regulators) will need to defer it's probe correctly too.
> For now it isn't true for many drivers and, for example,
> omap_hsmmc driver's probe will just fail if it can't get regulator.
> (+ problems with DSS - most probably Panel/DSI driver probe can't
> handle pin configuration)

Sounds like there are a few places to fix. Got something available
for these?
 
> Before, on early kernel versions, the OMAP pinmux was ready to work
> at arch_initcall time
> and most of the code has been created with this assumption.

Yes. In general we've been moving to initializing things later
on rather than earlier so we have a real console available for
error messages instead of earlyprintk if something goes wrong.

BTW, the legacy omap pinmux code will be going away as soon as
we have moved platforms to use DT only booting. I think we can
make omap4 DT only after v3.10, omap3 later on.
 
> Unfortunately, RTC is just a small part of problem.

Can you try just setting the related drivers to be regular
module initcalls and see if that solves the problem?

Regards,

Tony

      reply	other threads:[~2013-04-16 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 18:27 [BUG] omap: mfd/regulator: twl/core: init order Christoph Fritz
2013-04-15 10:20 ` Grygorii Strashko
2013-04-15 10:56   ` Christoph Fritz
2013-04-15 10:59     ` Grygorii Strashko
2013-04-15 16:25       ` Tony Lindgren
     [not found]         ` <20130415162541.GO10155-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-04-16  7:45           ` Peter Ujfalusi
2013-04-16  8:33             ` Grygorii Strashko
2013-04-16 17:54               ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130416175438.GR10155@atomide.com \
    --to=tony@atomide.com \
    --cc=a.zummo@towertech.it \
    --cc=b-cousson@ti.com \
    --cc=chf.fritz@googlemail.com \
    --cc=daniel@zonque.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grygorii.strashko@ti.com \
    --cc=hjk@hansjkoch.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).