From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2 Date: Wed, 17 Apr 2013 16:08:43 +0100 Message-ID: <20130417150843.5A5A63E2B73@localhost> References: <201304021630.13371.arnd@arndb.de> <20130417115357.0b0f31ae@redhat.com> Return-path: In-Reply-To: <20130417115357.0b0f31ae@redhat.com> Sender: linux-media-owner@vger.kernel.org To: Mauro Carvalho Chehab , Rob Herring Cc: Guennadi Liakhovetski , Arnd Bergmann , devicetree-discuss@lists.ozlabs.org, Linux Media Mailing List , Sylwester Nawrocki List-Id: devicetree@vger.kernel.org On Wed, 17 Apr 2013 11:53:57 -0300, Mauro Carvalho Chehab wrote: > Hi Grant/Rob, > > Our tree is currently _broken_ with OT, because of the lack of > exporting of_get_next_parent. The developer that submitted the patches > that added V4L2 OF support forgot to test to compilation with MODULES > support enabled. > > So, we're now having: > ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined! > > if compiled with OF enabled and media as module. > > As those patches were applied at my master branch and there are lots of > other patches on the top of the patches that added V4L2 OF support, > I prefer to avoid reverting those patches. > > On the other hand, I can't send the patches upstream next week (assuming > that -rc7 is the final one), without having this patch applying before > the media tree. The fix needs to be applied to your tree then. Go ahead and apply it with my ack: Acked-by: Grant Likely It is no good to apply it to the devicetree -next branch because that will still leave your branch broken, even if device tree gets merged first. g.