From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC Date: Wed, 17 Apr 2013 17:00:15 +0100 Message-ID: <20130417160015.777453E2B73@localhost> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130416103005.GB12726@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Murray , "linux-mips@linux-mips.org" , "linuxppc-dev@lists.ozlabs.org" Cc: "siva.kallam@samsung.com" , "linux-pci@vger.kernel.org" , "linus.walleij@linaro.org" , "thierry.reding@avionic-design.de" , Liviu Dudau , "paulus@samba.org" , "linux-samsung-soc@vger.kernel.org" , "linux@arm.linux.org.uk" , "jg1.han@samsung.com" , "jgunthorpe@obsidianresearch.com" , "thomas.abraham@linaro.org" , "benh@kernel.crashing.org" , "arnd@arndb.de" , "devicetree-discuss@lists.ozlabs.org" , "rob.herring@calxeda.com" , "kgene.kim@samsung.com" , bhelgaas List-Id: devicetree@vger.kernel.org On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g.