From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC Date: Wed, 17 Apr 2013 12:10:36 -0400 Message-ID: <20130417161036.GB27197@titan.lakedaemon.net> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> <20130417160015.777453E2B73@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130417160015.777453E2B73@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Grant Likely Cc: "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , "siva.kallam-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Liviu Dudau , "paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org" , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andrew Lunn , suren List-Id: devicetree@vger.kernel.org On Wed, Apr 17, 2013 at 05:00:15PM +0100, Grant Likely wrote: > On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > > property of a PCI host device, is found in both Microblaze and PowerPC > > > architectures. These implementations are nearly identical. This patch > > > moves this common code to a common place. > > > > > > Signed-off-by: Andrew Murray > > > Signed-off-by: Liviu Dudau > > > Reviewed-by: Rob Herring > > > Tested-by: Thomas Petazzoni > > > Tested-by: Linus Walleij > > > Acked-by: Michal Simek > > > --- > > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > > > I've tested that it builds on powerpc with a variety of configs (some which > > include fsl_pci.c implementation). Though I don't have hardware to verify that > > it works. > > > > I haven't tested this builds or runs on MIPS. > > > > You shouldn't see any difference in behaviour or new warnings and PCI devices > > should continue to operate as before. > > I've got through a line-by-line comparison between powerpc, microblaze, > and then new code. The differences are purely cosmetic, so I have > absolutely no concerns about this patch. I've applied it to my tree. oops. Due to the number of dependencies the mvebu-pcie series has (this being one of them, we (arm-soc/mvebu) asked if we could take this through our tree. Rob Herring agreed to this several days ago. Is this a problem for you? It would truly (dogs and cats living together) upset the apple cart for us at this stage to pipe these through a different tree... thx, Jason.