* [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe()
@ 2013-04-19 2:11 Wei Yongjun
2013-04-19 12:07 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-04-19 2:11 UTC (permalink / raw)
To: cjb, grant.likely, rob.herring, shawn.guo, marex, fabio.estevam,
broonie
Cc: yongjun_wei, linux-mmc, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENODEV in the request dma error case instead
of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mmc/host/mxs-mmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index 4278a17..a09ba6e 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -639,6 +639,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
if (!ssp->dmach) {
dev_err(mmc_dev(host->mmc),
"%s: failed to request dma\n", __func__);
+ ret = -ENODEV;
goto out_clk_put;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe()
2013-04-19 2:11 [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe() Wei Yongjun
@ 2013-04-19 12:07 ` Marek Vasut
2013-05-26 17:29 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2013-04-19 12:07 UTC (permalink / raw)
To: Wei Yongjun
Cc: cjb, grant.likely, rob.herring, shawn.guo, fabio.estevam, broonie,
yongjun_wei, linux-mmc, devicetree-discuss
Dear Wei Yongjun,
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV in the request dma error case instead
> of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Seems ok to me.
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe()
2013-04-19 12:07 ` Marek Vasut
@ 2013-05-26 17:29 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-05-26 17:29 UTC (permalink / raw)
To: Marek Vasut
Cc: Wei Yongjun, grant.likely, rob.herring, shawn.guo, fabio.estevam,
broonie, yongjun_wei, linux-mmc, devicetree-discuss
Hi,
On Fri, Apr 19 2013, Marek Vasut wrote:
> Dear Wei Yongjun,
>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return -ENODEV in the request dma error case instead
>> of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Seems ok to me.
>
> Reviewed-by: Marek Vasut <marex@denx.de>
Thanks, pushed to mmc-next for 3.11.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-26 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 2:11 [PATCH -next] mmc: mxs-mmc: fix error return code in mxs_mmc_probe() Wei Yongjun
2013-04-19 12:07 ` Marek Vasut
2013-05-26 17:29 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).