From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Subject: Re: [PATCH 5/6] thermal:exynos4: Enable support for Exynos4412 SoCs
Date: Mon, 22 Apr 2013 08:35:28 +0200
Message-ID: <20130422083528.4c97db3b@amdc308.digital.local>
References: <1366389493-8239-1-git-send-email-l.majewski@samsung.com>
 <1366389493-8239-6-git-send-email-l.majewski@samsung.com>
 <CADGdYn5LTq7iwuP0Hx=7BpdgQBU=Q7L-3pnSyu8MfQ0v3vVS1A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
In-reply-to: <CADGdYn5LTq7iwuP0Hx=7BpdgQBU=Q7L-3pnSyu8MfQ0v3vVS1A@mail.gmail.com>
Sender: linux-samsung-soc-owner@vger.kernel.org
To: amit kachhap <amit.kachhap@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>, Mike Turquette <mturquette@linaro.org>, Zhang Rui <rui.zhang@intel.com>, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, Linux PM list <linux-pm@vger.kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>
List-Id: devicetree@vger.kernel.org

Hi amit,

> Hi,
> 
> I have one suggestion,
> 
> On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski
> <l.majewski@samsung.com> wrote:
> > Enable TMU support for Exynos4412 based target with device tree.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  drivers/thermal/exynos_thermal.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/thermal/exynos_thermal.c
> > b/drivers/thermal/exynos_thermal.c index e922fa4..f54066d 100644
> > --- a/drivers/thermal/exynos_thermal.c
> > +++ b/drivers/thermal/exynos_thermal.c
> > @@ -819,6 +819,10 @@ static const struct of_device_id
> > exynos_tmu_match[] = { .data = (void *)EXYNOS4210_TMU_DRV_DATA,
> >         },
> >         {
> > +               .compatible = "samsung,exynos4412-tmu",
> > +               .data = (void *)EXYNOS_TMU_DRV_DATA,
> > +       },
> Instead of adding a new compatible string, "exynos5250-tmu" name can
> be re-used in the 4412 DT node file as 4412 and 5250 TMU controller
> are same.

Good point.

> 
> Thanks,
> Amit Daniel
> > +       {
> >                 .compatible = "samsung,exynos5250-tmu",
> >                 .data = (void *)EXYNOS_TMU_DRV_DATA,
> >         },
> > --
> > 1.7.10.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-samsung-soc" in the body of a message to
> > majordomo@vger.kernel.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html



-- 
Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group