From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 05/23] pinctrl: coh901: add device tree support
Date: Mon, 22 Apr 2013 13:40:17 +0200 [thread overview]
Message-ID: <201304221340.18080.arnd@arndb.de> (raw)
In-Reply-To: <1366624326-6259-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
On Monday 22 April 2013, Linus Walleij wrote:
> +Required properties:
> +- compatible: Compatible property value should be "stericsson,gpio-coh901"
> +- reg: Physical base address of the controller and length of memory mapped
> + region.
> +- interrupts: the 0...n interrupts assigned to the different GPIO ports/banks.
> +- interrupt-names: name the interrupts after port/bank, "gpio0", "gpio1" etc.
> +
I think it would be better to leave out the interrupt-names in this case, since
the name directly corresponds to the index, so there is no ambiguity.
Arnd
prev parent reply other threads:[~2013-04-22 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 9:52 [PATCH 05/23] pinctrl: coh901: add device tree support Linus Walleij
[not found] ` <1366624326-6259-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2013-04-22 11:40 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304221340.18080.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).