From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 05/23] pinctrl: coh901: add device tree support Date: Mon, 22 Apr 2013 13:40:17 +0200 Message-ID: <201304221340.18080.arnd@arndb.de> References: <1366624326-6259-1-git-send-email-linus.walleij@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366624326-6259-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Linus Walleij Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday 22 April 2013, Linus Walleij wrote: > +Required properties: > +- compatible: Compatible property value should be "stericsson,gpio-coh901" > +- reg: Physical base address of the controller and length of memory mapped > + region. > +- interrupts: the 0...n interrupts assigned to the different GPIO ports/banks. > +- interrupt-names: name the interrupts after port/bank, "gpio0", "gpio1" etc. > + I think it would be better to leave out the interrupt-names in this case, since the name directly corresponds to the index, so there is no ambiguity. Arnd