From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v5 01/10] ASoC: phycore-ac97: Add DT support Date: Wed, 24 Apr 2013 21:45:40 +0200 Message-ID: <20130424194540.GF32299@pengutronix.de> References: <1366814199-14827-1-git-send-email-mpa@pengutronix.de> <1366814199-14827-2-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1366814199-14827-2-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Markus Pargmann Cc: Fabio Estevam , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Lars-Peter Clausen , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mark Brown , Liam Girdwood , Timur Tabi , Sascha Hauer , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Markus, On Wed, Apr 24, 2013 at 04:36:30PM +0200, Markus Pargmann wrote: > Add devicetree support for this audio soc fabric driver. > > @@ -32,8 +35,12 @@ static struct snd_soc_dai_link imx_phycore_dai_ac97[] = { > .stream_name = "HiFi", > .codec_dai_name = "wm9712-hifi", > .codec_name = "wm9712-codec", > +#ifdef CONFIG_MACH_IMX27_DT > + .platform_name = "imx-fiq-pcm-audio", > +#else > .cpu_dai_name = "imx-ssi.0", > .platform_name = "imx-fiq-pcm-audio.0", > +#endif This doesn't work properly. Compiling the kernel with IMX27_DT enabled does not necessarily mean that it also started with dt support. Personally I am fine with removing platform based support for this driver if it's too much effort to fix it properly, but we shouldn't start working with ifdefs here. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |