From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: grant.likely@linaro.org, rob.herring@calxeda.com,
edumazet@google.com, fabio.estevam@freescale.com,
jiri@resnulli.us, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] net: calxedaxgmac: fix condition in xgmac_set_features()
Date: Thu, 25 Apr 2013 03:50:48 -0400 (EDT) [thread overview]
Message-ID: <20130425.035048.266657036340116086.davem@davemloft.net> (raw)
In-Reply-To: <20130425074420.GA11880@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 25 Apr 2013 10:44:20 +0300
> The "changed" variable should be a 64 bit type, otherwise it can't store
> all the features. The way the code is now the test for whether
> NETIF_F_RXCSUM changed is always false and we return immediately.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2013-04-25 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 7:44 [patch -next] net: calxedaxgmac: fix condition in xgmac_set_features() Dan Carpenter
2013-04-25 7:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425.035048.266657036340116086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=edumazet@google.com \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).