From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch -next] net: calxedaxgmac: fix condition in xgmac_set_features() Date: Thu, 25 Apr 2013 03:50:48 -0400 (EDT) Message-ID: <20130425.035048.266657036340116086.davem@davemloft.net> References: <20130425074420.GA11880@elgon.mountain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130425074420.GA11880@elgon.mountain> Sender: netdev-owner@vger.kernel.org To: dan.carpenter@oracle.com Cc: grant.likely@linaro.org, rob.herring@calxeda.com, edumazet@google.com, fabio.estevam@freescale.com, jiri@resnulli.us, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org List-Id: devicetree@vger.kernel.org From: Dan Carpenter Date: Thu, 25 Apr 2013 10:44:20 +0300 > The "changed" variable should be a 64 bit type, otherwise it can't store > all the features. The way the code is now the test for whether > NETIF_F_RXCSUM changed is always false and we return immediately. > > Signed-off-by: Dan Carpenter Applied, thanks Dan.