From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Baltieri Subject: Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL() Date: Fri, 26 Apr 2013 12:19:08 +0200 Message-ID: <20130426101908.GA23032@balto.lan> References: <1366899214-22639-1-git-send-email-eduardo.valentin@ti.com> <1366899214-22639-3-git-send-email-eduardo.valentin@ti.com> <20130425174635.GB25783@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130425174635.GB25783@flint.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King Cc: Eduardo Valentin , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Grant Likely , Rob Herring , Hongbo Zhang , devicetree-discuss@lists.ozlabs.org, Linus Walleij List-Id: devicetree@vger.kernel.org On Thu, Apr 25, 2013 at 06:46:35PM +0100, Russell King wrote: > On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote: > > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c > > index 21419851..786d192 100644 > > --- a/drivers/thermal/db8500_cpufreq_cooling.c > > +++ b/drivers/thermal/db8500_cpufreq_cooling.c > > @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev) > > cpumask_set_cpu(0, &mask_val); > > cdev = cpufreq_cooling_register(&mask_val); > > > > - if (IS_ERR_OR_NULL(cdev)) { > > + if (IS_ERR(cdev)) { > > dev_err(&pdev->dev, "Failed to register cooling device\n"); > > return PTR_ERR(cdev); > > Correct. cpufreq_cooling_register() returns either an error-pointer or > a valid pointer. Acked-by: Fabio Baltieri ...but more of these are going to appear forever, was the proposed removal of IS_ERR_OR_NULL rejected? Can't find any new message about that on the list. Fabio -- Fabio Baltieri