From: Russell King <rmk@arm.linux.org.uk>
To: Fabio Baltieri <fabio.baltieri@linaro.org>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Hongbo Zhang <hongbo.zhang@stericsson.com>,
devicetree-discuss@lists.ozlabs.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL()
Date: Fri, 26 Apr 2013 12:03:34 +0100 [thread overview]
Message-ID: <20130426110334.GB4862@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20130426101908.GA23032@balto.lan>
On Fri, Apr 26, 2013 at 12:19:08PM +0200, Fabio Baltieri wrote:
> On Thu, Apr 25, 2013 at 06:46:35PM +0100, Russell King wrote:
> > On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote:
> > > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
> > > index 21419851..786d192 100644
> > > --- a/drivers/thermal/db8500_cpufreq_cooling.c
> > > +++ b/drivers/thermal/db8500_cpufreq_cooling.c
> > > @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev)
> > > cpumask_set_cpu(0, &mask_val);
> > > cdev = cpufreq_cooling_register(&mask_val);
> > >
> > > - if (IS_ERR_OR_NULL(cdev)) {
> > > + if (IS_ERR(cdev)) {
> > > dev_err(&pdev->dev, "Failed to register cooling device\n");
> > > return PTR_ERR(cdev);
> >
> > Correct. cpufreq_cooling_register() returns either an error-pointer or
> > a valid pointer.
>
> Acked-by: Fabio Baltieri <fabio.baltieri@linaro.org>
>
> ...but more of these are going to appear forever, was the proposed
> removal of IS_ERR_OR_NULL rejected? Can't find any new message about
> that on the list.
We first need to get rid of the existing users of it - I've got rid of
most of those in arch/arm - but it seems that I never pushed that in the
last merge window.
Really it needs the cooperation of everyone to make it happen across the
tree with everyone removing IS_ERR_OR_NULL() in their subsystem. There
are currently 366 instances of this macro being used in the entire tree
which is far too many to even mark it as deprecated.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2013-04-26 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1366899214-22639-1-git-send-email-eduardo.valentin@ti.com>
2013-04-25 14:13 ` [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL() Eduardo Valentin
2013-04-25 17:46 ` Russell King
2013-04-25 20:17 ` Eduardo Valentin
2013-04-26 10:19 ` Fabio Baltieri
2013-04-26 11:03 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426110334.GB4862@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eduardo.valentin@ti.com \
--cc=fabio.baltieri@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=hongbo.zhang@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).