devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: re: regulator: palma: add ramp delay support through regulator constraints
Date: Mon, 29 Apr 2013 20:32:28 +0300	[thread overview]
Message-ID: <20130429173228.GA7024@elgon.mountain> (raw)

Hello Laxman Dewangan,

The patch 28d1e8cd671a: "regulator: palma: add ramp delay support
through regulator constraints" from Apr 18, 2013, leads to the
following Smatch warning:
"drivers/regulator/palmas-regulator.c:843 palmas_regulators_probe()
	 warn: was || intended here instead of &&?"

drivers/regulator/palmas-regulator.c
   842  
   843                  if ((id == PALMAS_REG_SMPS6) && (id == PALMAS_REG_SMPS8))

"id" can't be equal to both.

   844                          ramp_delay_support = true;
   845  
   846                  if (ramp_delay_support) {
   847                          addr = palmas_regs_info[id].tstep_addr;
   848                          ret = palmas_smps_read(pmic->palmas, addr, &reg);
   849                          if (ret < 0) {

regards,
dan carpenter

                 reply	other threads:[~2013-04-29 17:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429173228.GA7024@elgon.mountain \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).