devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: regulator: palma: add ramp delay support through regulator constraints
@ 2013-04-29 17:32 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-04-29 17:32 UTC (permalink / raw)
  To: ldewangan-DDmLM1+adcrQT0dZR+AlfA
  Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ

Hello Laxman Dewangan,

The patch 28d1e8cd671a: "regulator: palma: add ramp delay support
through regulator constraints" from Apr 18, 2013, leads to the
following Smatch warning:
"drivers/regulator/palmas-regulator.c:843 palmas_regulators_probe()
	 warn: was || intended here instead of &&?"

drivers/regulator/palmas-regulator.c
   842  
   843                  if ((id == PALMAS_REG_SMPS6) && (id == PALMAS_REG_SMPS8))

"id" can't be equal to both.

   844                          ramp_delay_support = true;
   845  
   846                  if (ramp_delay_support) {
   847                          addr = palmas_regs_info[id].tstep_addr;
   848                          ret = palmas_smps_read(pmic->palmas, addr, &reg);
   849                          if (ret < 0) {

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-29 17:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 17:32 regulator: palma: add ramp delay support through regulator constraints Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).