From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: regulator: palma: add ramp delay support through regulator constraints Date: Mon, 29 Apr 2013 20:32:28 +0300 Message-ID: <20130429173228.GA7024@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Laxman Dewangan, The patch 28d1e8cd671a: "regulator: palma: add ramp delay support through regulator constraints" from Apr 18, 2013, leads to the following Smatch warning: "drivers/regulator/palmas-regulator.c:843 palmas_regulators_probe() warn: was || intended here instead of &&?" drivers/regulator/palmas-regulator.c 842 843 if ((id == PALMAS_REG_SMPS6) && (id == PALMAS_REG_SMPS8)) "id" can't be equal to both. 844 ramp_delay_support = true; 845 846 if (ramp_delay_support) { 847 addr = palmas_regs_info[id].tstep_addr; 848 ret = palmas_smps_read(pmic->palmas, addr, ®); 849 if (ret < 0) { regards, dan carpenter