From: Mark Brown <broonie@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com, balbi@ti.com,
ldewangan@nvidia.com, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
grant.likely@linaro.org, rob.herring@calxeda.com,
rob@landley.net, gg@slimlogic.co.uk, ruchika@ti.com,
tony@atomide.com, sameo@linux.intel.com
Subject: Re: [PATCH v4] extcon: Palmas Extcon Driver
Date: Mon, 6 May 2013 15:40:10 +0100 [thread overview]
Message-ID: <20130506144010.GF13472@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1367846225-15685-1-git-send-email-kishon@ti.com>
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote:
> + if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) {
> + if (palmas_usb->vbus_reg) {
> + ret = regulator_enable(palmas_usb->vbus_reg);
> + if (ret) {
> + dev_dbg(palmas_usb->dev,
> + "regulator enable failed\n");
> + goto ret0;
This is very bad karma, why is the regulator optional?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-06 14:40 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 13:21 [PATCH v2 0/4] usb: added palmas-usb driver and a few misc fixes Kishon Vijay Abraham I
[not found] ` <1362662506-14823-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-03-07 13:21 ` [PATCH v2 1/4] usb: dwc3: set dma_mask for dwc3_omap device Kishon Vijay Abraham I
2013-03-07 13:21 ` [PATCH v2 2/4] usb: dwc3: dwc3-omap: return -EPROBE_DEFER if probe has not yet executed Kishon Vijay Abraham I
2013-03-07 13:21 ` [PATCH v2 3/4] USB: Palmas OTG Transceiver Driver Kishon Vijay Abraham I
[not found] ` <1362662506-14823-4-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-03-14 13:56 ` Felipe Balbi
2013-03-14 14:53 ` kishon
2013-03-25 9:32 ` [PATCH v3] USB: PHY: Palmas USB " Kishon Vijay Abraham I
[not found] ` <1364203926-24488-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-03-25 9:46 ` Laxman Dewangan
2013-03-26 6:03 ` Kishon Vijay Abraham I
2013-03-26 9:01 ` Graeme Gregory
2013-03-26 9:12 ` Laxman Dewangan
2013-03-26 9:27 ` Graeme Gregory
2013-03-26 9:34 ` Laxman Dewangan
2013-03-26 9:51 ` Graeme Gregory
2013-03-26 11:28 ` Laxman Dewangan
[not found] ` <51516A10.40704-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>
2013-03-26 16:22 ` Stephen Warren
2013-03-26 16:57 ` Graeme Gregory
2013-03-26 20:23 ` Stephen Warren
2013-03-27 11:03 ` Graeme Gregory
2013-03-26 10:21 ` Felipe Balbi
2013-03-26 10:28 ` Laxman Dewangan
[not found] ` <51517859.2020407-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-26 12:07 ` Felipe Balbi
2013-03-26 16:14 ` Stephen Warren
2013-03-26 10:19 ` Felipe Balbi
2013-05-06 13:17 ` [PATCH v4] extcon: Palmas Extcon Driver Kishon Vijay Abraham I
2013-05-06 14:26 ` Laxman Dewangan
2013-05-07 5:06 ` Kishon Vijay Abraham I
2013-05-06 14:40 ` Mark Brown [this message]
2013-05-07 5:12 ` Kishon Vijay Abraham I
[not found] ` <51888D55.3090907-l0cyMroinI0@public.gmane.org>
2013-05-07 7:58 ` Mark Brown
2013-05-07 9:47 ` Kishon Vijay Abraham I
2013-05-07 9:49 ` Graeme Gregory
2013-05-07 10:45 ` Mark Brown
2013-05-14 9:18 ` Kishon Vijay Abraham I
2013-05-14 9:54 ` Graeme Gregory
2013-05-14 18:43 ` Laxman Dewangan
2013-05-07 0:43 ` myungjoo.ham
2013-05-07 5:21 ` Kishon Vijay Abraham I
2013-05-22 6:23 ` Kishon Vijay Abraham I
2013-05-07 6:10 ` Chanwoo Choi
2013-05-07 6:25 ` Kishon Vijay Abraham I
2013-05-07 6:57 ` Chanwoo Choi
2013-05-07 7:05 ` Chanwoo Choi
[not found] ` <5188A7BE.4080509-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-05-07 8:17 ` Kishon Vijay Abraham I
2013-03-07 13:21 ` [PATCH v2 4/4] usb: musb: omap2430: replace *_* with *-* in property names Kishon Vijay Abraham I
2013-03-14 13:57 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506144010.GF13472@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=balbi@ti.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=ruchika@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).