* [PATCH] net/spider_net: fix error return code in spider_net_open()
@ 2013-05-07 12:16 Wei Yongjun
2013-05-08 20:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-05-07 12:16 UTC (permalink / raw)
To: kou.ishizaki, jens, grant.likely, rob.herring
Cc: yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/toshiba/spider_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c
index c655fe6..5734480 100644
--- a/drivers/net/ethernet/toshiba/spider_net.c
+++ b/drivers/net/ethernet/toshiba/spider_net.c
@@ -1990,7 +1990,8 @@ spider_net_open(struct net_device *netdev)
goto alloc_rx_failed;
/* Allocate rx skbs */
- if (spider_net_alloc_rx_skbs(card))
+ result = spider_net_alloc_rx_skbs(card);
+ if (result)
goto alloc_skbs_failed;
spider_net_set_multi(netdev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/spider_net: fix error return code in spider_net_open()
2013-05-07 12:16 [PATCH] net/spider_net: fix error return code in spider_net_open() Wei Yongjun
@ 2013-05-08 20:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-08 20:15 UTC (permalink / raw)
To: weiyj.lk
Cc: kou.ishizaki, jens, grant.likely, rob.herring, yongjun_wei,
netdev, devicetree-discuss
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 7 May 2013 20:16:00 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-08 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 12:16 [PATCH] net/spider_net: fix error return code in spider_net_open() Wei Yongjun
2013-05-08 20:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).