From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [RFC 1/8] serial:st-asc: Add ST ASC driver. Date: Wed, 8 May 2013 17:40:57 +0200 Message-ID: <20130508154057.GB3041@game.jcrosoft.org> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022248-2153-1-git-send-email-srinivas.kandagatla@st.com> <201305081634.43498.arnd@arndb.de> <20130508153459.GA17186@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130508153459.GA17186-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Greg KH Cc: Mark Brown , Russell King , Samuel Ortiz , Srinivas KANDAGATLA , Viresh Kumar , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Nicolas Pitre , Will Deacon , Stephen Gallimore , Rob Herring , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stuart Menefy , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dong Aisheng , jslaby-AlSwsSmVLrQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper List-Id: devicetree@vger.kernel.org On 08:34 Wed 08 May , Greg KH wrote: > On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > > > +#define ASC_MAJOR 204 > > > +#define ASC_MINOR_START 40 > > > > I don't know what the current policy is on allocating major/minor numbers, > > but I'm sure you cannot just reuse one that is already used. > > I agree, why are you trying to create a new tty device name? Can't you > use the existing ttyS name and minor number as you will not have any > other type of serial device on this system? Greg on ST STB for more than 10 years we use ttyASC I'll prefer ttySx on the DTB SoC you have one one IP present the st,asc Best Regards, J. > > thanks, > > greg k-h > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/devicetree-discuss